Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8296485: BuildEEBasicConstraints.java test fails with SunCertPathBuilderException #1509

Closed

Conversation

Rudometov
Copy link
Member

@Rudometov Rudometov commented Nov 8, 2022

Backport for JDK-8296485 BuildEEBasicConstraints.java test fails with SunCertPathBuilderException

Clean backport, test fix, low risk.
Test fails before the fix passes after the fix.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8296485: BuildEEBasicConstraints.java test fails with SunCertPathBuilderException

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1509/head:pull/1509
$ git checkout pull/1509

Update a local copy of the PR:
$ git checkout pull/1509
$ git pull https://git.openjdk.org/jdk11u-dev pull/1509/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1509

View PR using the GUI difftool:
$ git pr show -t 1509

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1509.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 8, 2022

👋 Welcome back vrudomet! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 520db1eeb18797c782ddfad90467e19bbdd424ac 8296485: BuildEEBasicConstraints.java test fails with SunCertPathBuilderException Nov 8, 2022
@openjdk
Copy link

openjdk bot commented Nov 8, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 8, 2022

@Rudometov This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8296485: BuildEEBasicConstraints.java test fails with SunCertPathBuilderException

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • dde20e4: 8288132: Update test artifacts in QuoVadis CA interop tests
  • 6664437: 8268361: Fix the infinite loop in next_line

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 8, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 8, 2022

Webrevs

@Rudometov
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 9, 2022
@openjdk
Copy link

openjdk bot commented Nov 9, 2022

@Rudometov
Your change (at version 0dac4f8) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 9, 2022

Going to push as commit ca885ee.
Since your change was applied there have been 2 commits pushed to the master branch:

  • dde20e4: 8288132: Update test artifacts in QuoVadis CA interop tests
  • 6664437: 8268361: Fix the infinite loop in next_line

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 9, 2022
@openjdk openjdk bot closed this Nov 9, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 9, 2022
@openjdk
Copy link

openjdk bot commented Nov 9, 2022

@phohensee @Rudometov Pushed as commit ca885ee.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants