Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8264666: Change implementation of safeAdd/safeMult in the LCMSImageLayout class #1522

Closed
wants to merge 1 commit into from

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Nov 15, 2022

backport of 8264666


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8264666: Change implementation of safeAdd/safeMult in the LCMSImageLayout class

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1522/head:pull/1522
$ git checkout pull/1522

Update a local copy of the PR:
$ git checkout pull/1522
$ git pull https://git.openjdk.org/jdk11u-dev pull/1522/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1522

View PR using the GUI difftool:
$ git pr show -t 1522

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1522.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 15, 2022

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 3ef9ce6c02784abe3b3b55e4d490554436bf5991 8264666: Change implementation of safeAdd/safeMult in the LCMSImageLayout class Nov 15, 2022
@openjdk
Copy link

openjdk bot commented Nov 15, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Nov 15, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 15, 2022

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@openjdk
Copy link

openjdk bot commented Nov 15, 2022

@MBaesken This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8264666: Change implementation of safeAdd/safeMult in the LCMSImageLayout class

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • b7b00f7: 8296108: (tz) Update Timezone Data to 2022f
  • e3eccbc: 8294307: ISO 4217 Amendment 173 Update
  • 954a6e4: 8286872: Refactor add/modify notification icon (TrayIcon)
  • f2f7be9: 8202836: [macosx] test java/awt/Graphics/TextAAHintsTest.java fails

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 15, 2022
@MBaesken
Copy link
Member Author

Hi Paul, thanks for the review.

@MBaesken
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 16, 2022

Going to push as commit 55354dd.
Since your change was applied there have been 5 commits pushed to the master branch:

  • 1549bb1: 8288302: Shenandoah: SIGSEGV in vm maybe related to jit compiling xerces
  • b7b00f7: 8296108: (tz) Update Timezone Data to 2022f
  • e3eccbc: 8294307: ISO 4217 Amendment 173 Update
  • 954a6e4: 8286872: Refactor add/modify notification icon (TrayIcon)
  • f2f7be9: 8202836: [macosx] test java/awt/Graphics/TextAAHintsTest.java fails

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 16, 2022
@openjdk openjdk bot closed this Nov 16, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 16, 2022
@openjdk
Copy link

openjdk bot commented Nov 16, 2022

@MBaesken Pushed as commit 55354dd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants