New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8264666: Change implementation of safeAdd/safeMult in the LCMSImageLayout class #1522
Conversation
👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm.
@MBaesken This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 4 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
Hi Paul, thanks for the review. |
/integrate |
Going to push as commit 55354dd.
Your commit was automatically rebased without conflicts. |
backport of 8264666
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1522/head:pull/1522
$ git checkout pull/1522
Update a local copy of the PR:
$ git checkout pull/1522
$ git pull https://git.openjdk.org/jdk11u-dev pull/1522/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1522
View PR using the GUI difftool:
$ git pr show -t 1522
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1522.diff