Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8287425: Remove unnecessary register push for MacroAssembler::check_klass_subtype_slow_path #1524

Closed

Conversation

parttimenerd
Copy link
Contributor

@parttimenerd parttimenerd commented Nov 16, 2022

Removes an unnecessary register push which currently makes stack walking impossible for async-profiler.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8287425: Remove unnecessary register push for MacroAssembler::check_klass_subtype_slow_path

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1524/head:pull/1524
$ git checkout pull/1524

Update a local copy of the PR:
$ git checkout pull/1524
$ git pull https://git.openjdk.org/jdk11u-dev pull/1524/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1524

View PR using the GUI difftool:
$ git pr show -t 1524

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1524.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 16, 2022

👋 Welcome back parttimenerd! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport b5a646ee6cfd432cef6b7e69a177959227a38ace 8287425: Remove unnecessary register push for MacroAssembler::check_klass_subtype_slow_path Nov 16, 2022
@openjdk
Copy link

openjdk bot commented Nov 16, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Nov 16, 2022
Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a clean backport from 17u, so lgtm on the actual patch, other than the jcheck failure (you're got extra whitespace somewhere). But, as the bot says, a description is needed, and also a test report. The 17u backport passed tier1 and tier2 on x86 and aarch64.

@parttimenerd
Copy link
Contributor Author

Thanks. I'll do it tomorrow.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 21, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 21, 2022

Webrevs

@adinn
Copy link
Contributor

adinn commented Nov 21, 2022

/clean

@openjdk openjdk bot added the clean label Nov 21, 2022
@openjdk
Copy link

openjdk bot commented Nov 21, 2022

@adinn This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented Nov 21, 2022

@parttimenerd This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8287425: Remove unnecessary register push for MacroAssembler::check_klass_subtype_slow_path

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • 5d9c09b: 8283199: Linux os::cpu_microcode_revision() stalls cold startup
  • 7e6c47d: 8294740: Add cgroups keyword to TestDockerBasic.java
  • 9eac68b: 8293540: [Metrics] Incorrectly detected resource limits with additional cgroup fs mounts
  • 7706fa8: 8293472: Incorrect container resource limit detection if manual cgroup fs mounts present
  • 4ee685a: 8029633: Raw inner class constructor ref should not perform diamond inference
  • 1f17371: 8296652: Restore windows aarch64 fixpath patch that was removed in 8239708
  • 5043784: 8256109: Create implementation for NSAccessibilityButton protocol

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 21, 2022
@adinn
Copy link
Contributor

adinn commented Nov 21, 2022

@parttimenerd This is now just waiting on a maintainer to ack the fix request.

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@parttimenerd
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 21, 2022
@openjdk
Copy link

openjdk bot commented Nov 21, 2022

@parttimenerd
Your change (at version 93f9bee) is now ready to be sponsored by a Committer.

@adinn
Copy link
Contributor

adinn commented Nov 21, 2022

@parttimenerd this has not yet had the fix request acked on the JIRA which is needed before anyone is supposed to sponsor it.

@parttimenerd
Copy link
Contributor Author

parttimenerd commented Nov 21, 2022

Oh, thanks for mentioning that, I forgot that my fix request was pending.

@adinn
Copy link
Contributor

adinn commented Nov 21, 2022

@GoeLin would you be able to ack the fix request for jdk11u?

@RealCLanger
Copy link
Contributor

Approved.

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 22, 2022

Going to push as commit 7340e1b.
Since your change was applied there have been 9 commits pushed to the master branch:

  • 7964440: 8286624: Regression Test CoordinateTruncationBug.java fails on OL8.3
  • 1459277: 8296632: Write a test to verify the content change of TextArea sends TextEvent
  • 5d9c09b: 8283199: Linux os::cpu_microcode_revision() stalls cold startup
  • 7e6c47d: 8294740: Add cgroups keyword to TestDockerBasic.java
  • 9eac68b: 8293540: [Metrics] Incorrectly detected resource limits with additional cgroup fs mounts
  • 7706fa8: 8293472: Incorrect container resource limit detection if manual cgroup fs mounts present
  • 4ee685a: 8029633: Raw inner class constructor ref should not perform diamond inference
  • 1f17371: 8296652: Restore windows aarch64 fixpath patch that was removed in 8239708
  • 5043784: 8256109: Create implementation for NSAccessibilityButton protocol

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 22, 2022
@openjdk openjdk bot closed this Nov 22, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 22, 2022
@openjdk
Copy link

openjdk bot commented Nov 22, 2022

@RealCLanger @parttimenerd Pushed as commit 7340e1b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@parttimenerd parttimenerd deleted the parttimenerd_8287425 branch November 24, 2022 17:41
@parttimenerd parttimenerd restored the parttimenerd_8287425 branch November 30, 2022 10:19
@parttimenerd parttimenerd deleted the parttimenerd_8287425 branch November 30, 2022 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
4 participants