Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8022403: sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java fails #1529

Closed
wants to merge 1 commit into from

Conversation

Rudometov
Copy link
Member

@Rudometov Rudometov commented Nov 18, 2022

Backport for JDK-8022403 sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java fails

Cherry-picked from openjdk/jdk@65f7de2

Clean test backport, had to merge ProblemList.txt.
Test update, low risk.
Test passed during manual run using cmd:
make run-test TEST=test/jdk/sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8022403: sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java fails

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1529/head:pull/1529
$ git checkout pull/1529

Update a local copy of the PR:
$ git checkout pull/1529
$ git pull https://git.openjdk.org/jdk11u-dev pull/1529/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1529

View PR using the GUI difftool:
$ git pr show -t 1529

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1529.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 18, 2022

👋 Welcome back vrudomet! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 65f7de252366e30ba18a22c107fc301c0fdc9378 8022403: sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java fails Nov 18, 2022
@openjdk
Copy link

openjdk bot commented Nov 18, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Nov 18, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 18, 2022

Webrevs

@openjdk openjdk bot added the clean label Nov 18, 2022
@openjdk
Copy link

openjdk bot commented Nov 18, 2022

@Rudometov This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8022403: sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java fails

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 7e6c47d: 8294740: Add cgroups keyword to TestDockerBasic.java
  • 9eac68b: 8293540: [Metrics] Incorrectly detected resource limits with additional cgroup fs mounts
  • 7706fa8: 8293472: Incorrect container resource limit detection if manual cgroup fs mounts present
  • 4ee685a: 8029633: Raw inner class constructor ref should not perform diamond inference

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 18, 2022
@openjdk-notifier
Copy link

@Rudometov Please do not rebase or force-push to an active PR as it invalidates existing review comments. All changes will be squashed into a single commit automatically when integrating. See OpenJDK Developers’ Guide for more information.

@Rudometov
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 21, 2022
@openjdk
Copy link

openjdk bot commented Nov 21, 2022

@Rudometov
Your change (at version 57925c6) is now ready to be sponsored by a Committer.

@Rudometov
Copy link
Member Author

Will wait a bit for this test to stabilize before integrating. There is at least one more fix for this test in JDK-8297153 (openjdk/jdk@3c09498)

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 22, 2022

Going to push as commit c488e04.
Since your change was applied there have been 13 commits pushed to the master branch:

  • 597a800: 8285604: closed sun/java2d/GdiRendering/ClipShapeRendering.java failed with "Incorrect color ffeeeeee instead of ff0000ff in pixel (100, 100)"
  • 5711197: 8178698: javax/sound/midi/Sequencer/MetaCallback.java failed with timeout
  • 18055b8: 8287896: PropertiesTest.sh fail on msys2
  • 3bdd370: 8287895: Some langtools tests fail on msys2
  • f27d48e: 8287902: UnreadableRB case in MissingResourceCauseTest is not working reliably on Windows
  • 7340e1b: 8287425: Remove unnecessary register push for MacroAssembler::check_klass_subtype_slow_path
  • 7964440: 8286624: Regression Test CoordinateTruncationBug.java fails on OL8.3
  • 1459277: 8296632: Write a test to verify the content change of TextArea sends TextEvent
  • 5d9c09b: 8283199: Linux os::cpu_microcode_revision() stalls cold startup
  • 7e6c47d: 8294740: Add cgroups keyword to TestDockerBasic.java
  • ... and 3 more: https://git.openjdk.org/jdk11u-dev/compare/1f173716812a570fe6b6eaf685ec90f66a840792...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 22, 2022
@openjdk openjdk bot closed this Nov 22, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 22, 2022
@openjdk
Copy link

openjdk bot commented Nov 22, 2022

@phohensee @Rudometov Pushed as commit c488e04.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@Rudometov Rudometov deleted the 8022403 branch January 20, 2023 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
3 participants