Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8235211: serviceability/attach/RemovingUnixDomainSocketTest.java fails with AttachNotSupportedException: Unable to open socket file #153

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Jul 22, 2021

Clean backport of JDK-8235211. Test backport is not clean. I had to integrate it manually and add the simple change JDK-8244973 because out.stderrShouldBeEmptyIgnoreVMWarnings().stderrShouldBeEmpty(); is neither correct, nor supported in 11u.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issues

  • JDK-8235211: serviceability/attach/RemovingUnixDomainSocketTest.java fails with AttachNotSupportedException: Unable to open socket file
  • JDK-8244973: serviceability/attach/RemovingUnixDomainSocketTest.java fails "stderr was not empty"

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/153/head:pull/153
$ git checkout pull/153

Update a local copy of the PR:
$ git checkout pull/153
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/153/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 153

View PR using the GUI difftool:
$ git pr show -t 153

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/153.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 22, 2021

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 073e095e6053550b17b1daf33df2be4f4c4b40ad 8235211: serviceability/attach/RemovingUnixDomainSocketTest.java fails with AttachNotSupportedException: Unable to open socket file Jul 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 22, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr labels Jul 22, 2021
@TheRealMDoerr
Copy link
Contributor Author

@TheRealMDoerr TheRealMDoerr commented Jul 22, 2021

/issue add JDK-8244973

@openjdk
Copy link

@openjdk openjdk bot commented Jul 22, 2021

@TheRealMDoerr
Adding additional issue to issue list: 8244973: serviceability/attach/RemovingUnixDomainSocketTest.java fails "stderr was not empty".

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 22, 2021

Webrevs

Copy link
Member

@MBaesken MBaesken left a comment

Hi Martin, shouldn't there be similar changes done for linux/aix/bsd as well in src/hotspot/os/solaris/attachListener_solaris.cpp (e.g. the "// avoid deadlock if AttachListener thread is blocked at safepoint" code). or this this for some reason not needed on Solaris ?
We have a _door_descriptor on Solaris instead of the file descriptor named _listener .

@TheRealMDoerr
Copy link
Contributor Author

@TheRealMDoerr TheRealMDoerr commented Jul 23, 2021

Hi Matthias,
thanks for looking into this.
Solaris is discontinued in 11.0.13 (see mail "[11u] : SAP terminates solaris sparc support." from Götz Lindenmaier). We are no longer investigating, building or testing. If anybody wants to revive SPARC, that person should probably change attachListener_solaris.cpp, too, but there's probably nobody who would do it.

@openjdk
Copy link

@openjdk openjdk bot commented Jul 23, 2021

@TheRealMDoerr This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8235211: serviceability/attach/RemovingUnixDomainSocketTest.java fails with AttachNotSupportedException: Unable to open socket file
8244973: serviceability/attach/RemovingUnixDomainSocketTest.java fails "stderr was not empty"

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 7501084: 8268965: TCP Connection Reset when connecting simple socket to SSL server

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jul 23, 2021
@TheRealMDoerr
Copy link
Contributor Author

@TheRealMDoerr TheRealMDoerr commented Jul 23, 2021

Thanks for the review and the approval!
/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jul 23, 2021

Going to push as commit 133eca0.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 7501084: 8268965: TCP Connection Reset when connecting simple socket to SSL server

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jul 23, 2021
@openjdk openjdk bot added integrated and removed ready labels Jul 23, 2021
@TheRealMDoerr TheRealMDoerr deleted the 8235211_AttachNotSupportedException branch Jul 23, 2021
@openjdk openjdk bot removed the rfr label Jul 23, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 23, 2021

@TheRealMDoerr Pushed as commit 133eca0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated
2 participants