Skip to content

Conversation

@backwaterred
Copy link
Contributor

@backwaterred backwaterred commented Nov 18, 2022

See comments in #1530

This backport requires a review. It is not marked clean because it does not make the change to jaxp/TEST.ROOT from the original commit. I kept the version bumped by 00d9483.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Integration blocker

 ⚠️ Dependency #1530 must be integrated first

Issue

  • JDK-8219705: Wrong media-type for a given serialization method

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1531/head:pull/1531
$ git checkout pull/1531

Update a local copy of the PR:
$ git checkout pull/1531
$ git pull https://git.openjdk.org/jdk11u-dev pull/1531/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1531

View PR using the GUI difftool:
$ git pr show -t 1531

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1531.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 18, 2022

👋 Welcome back tsteele! A progress list of the required criteria for merging this PR into pr/1530 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport b238aef18d56ad87ab954e3ceac797c234b3f3bf 8219705: Wrong media-type for a given serialization method Nov 18, 2022
@openjdk
Copy link

openjdk bot commented Nov 18, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport Port of a pull request already in a different code base label Nov 18, 2022
@backwaterred backwaterred marked this pull request as ready for review November 18, 2022 23:09
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 18, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 18, 2022

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@backwaterred
Copy link
Contributor Author

Thanks for the review.

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 20, 2022

@backwaterred This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@phohensee
Copy link
Member

@backwaterred, please tag the JBS issue.

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 8, 2023

@backwaterred This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 8, 2023

@backwaterred This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants