Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8268860: Windows-Aarch64 build is failing in GitHub actions #1538

Closed
wants to merge 6 commits into from

Conversation

gdams
Copy link
Member

@gdams gdams commented Nov 21, 2022

Applies cleanly except for the change added in 5d28a71


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8268860: Windows-Aarch64 build is failing in GitHub actions

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1538/head:pull/1538
$ git checkout pull/1538

Update a local copy of the PR:
$ git checkout pull/1538
$ git pull https://git.openjdk.org/jdk11u-dev pull/1538/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1538

View PR using the GUI difftool:
$ git pr show -t 1538

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1538.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 21, 2022

👋 Welcome back gdams! A progress list of the required criteria for merging this PR into pr/1278 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport acc3d995355b646c581623b0df5facbcdbfa4721 8268860: Windows-Aarch64 build is failing in GitHub actions Nov 21, 2022
@openjdk
Copy link

openjdk bot commented Nov 21, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Nov 21, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 21, 2022

Webrevs

@openjdk-notifier
Copy link

@gdams Please do not rebase or force-push to an active PR as it invalidates existing review comments. All changes will be squashed into a single commit automatically when integrating. See OpenJDK Developers’ Guide for more information.

@gdams gdams changed the base branch from pr/1278 to master November 25, 2022 09:00
@openjdk
Copy link

openjdk bot commented Nov 25, 2022

@gdams This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8268860: Windows-Aarch64 build is failing in GitHub actions

Reviewed-by: clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 25, 2022
@gdams
Copy link
Member Author

gdams commented Nov 25, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Nov 25, 2022

Going to push as commit bc704da.
Since your change was applied there have been 2 commits pushed to the master branch:

  • af27be3: 8287724: Fix various issues with msys2
  • 99b722d: 8226236: win32: gc/metaspace/TestCapacityUntilGCWrapAround.java fails

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 25, 2022
@openjdk openjdk bot closed this Nov 25, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 25, 2022
@openjdk
Copy link

openjdk bot commented Nov 25, 2022

@gdams Pushed as commit bc704da.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants