Skip to content

8287902: UnreadableRB case in MissingResourceCauseTest is not working reliably on Windows #1542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

gdams
Copy link
Member

@gdams gdams commented Nov 21, 2022

This pull request contains a backport of JDK-8287902, commit 975316e3 from the openjdk/jdk repository.

The commit being backported was authored by Magnus Ihse Bursie on 10 Jun 2022 and was reviewed by Naoto Sato.

It fixes an issue that shows up in the new style GHA workflow.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8287902: UnreadableRB case in MissingResourceCauseTest is not working reliably on Windows

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1542/head:pull/1542
$ git checkout pull/1542

Update a local copy of the PR:
$ git checkout pull/1542
$ git pull https://git.openjdk.org/jdk11u-dev pull/1542/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1542

View PR using the GUI difftool:
$ git pr show -t 1542

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1542.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 21, 2022

👋 Welcome back gdams! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 975316e3e5f1208e4e15eadc2493d25c15554647 8287902: UnreadableRB case in MissingResourceCauseTest is not working reliably on Windows Nov 21, 2022
@openjdk
Copy link

openjdk bot commented Nov 21, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 21, 2022

@gdams This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8287902: UnreadableRB case in MissingResourceCauseTest is not working reliably on Windows

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 7340e1b: 8287425: Remove unnecessary register push for MacroAssembler::check_klass_subtype_slow_path
  • 7964440: 8286624: Regression Test CoordinateTruncationBug.java fails on OL8.3

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 21, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 21, 2022

Webrevs

@gdams
Copy link
Member Author

gdams commented Nov 22, 2022

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 22, 2022
@openjdk
Copy link

openjdk bot commented Nov 22, 2022

@gdams
Your change (at version 37e76bc) is now ready to be sponsored by a Committer.

@gdams
Copy link
Member Author

gdams commented Nov 22, 2022

/sponsor

@RealCLanger
Copy link
Contributor

@gdams Weird that you still need a sponsor. Maybe the Skara bots are checking the JDK repository for committer status (which would be wrong...)

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 22, 2022

@gdams Only Committers are allowed to sponsor changes.

@openjdk
Copy link

openjdk bot commented Nov 22, 2022

Going to push as commit f27d48e.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 7340e1b: 8287425: Remove unnecessary register push for MacroAssembler::check_klass_subtype_slow_path
  • 7964440: 8286624: Regression Test CoordinateTruncationBug.java fails on OL8.3

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 22, 2022
@openjdk openjdk bot closed this Nov 22, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 22, 2022
@openjdk
Copy link

openjdk bot commented Nov 22, 2022

@RealCLanger @gdams Pushed as commit f27d48e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@gdams gdams deleted the unreadable branch November 22, 2022 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants