Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8261350: Create implementation for NSAccessibilityCheckBox protocol peer #1550

Closed
wants to merge 4 commits into from

Conversation

Autumn808
Copy link
Contributor

@Autumn808 Autumn808 commented Nov 23, 2022

JDK-8261350 Mostly clean each backport seems to just be cleaning up the java.desktop/macosx/native/libawt_lwawt/awt/a11y/RadiobuttonAccessibility.m file so it aligns properly.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8261350: Create implementation for NSAccessibilityCheckBox protocol peer

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1550/head:pull/1550
$ git checkout pull/1550

Update a local copy of the PR:
$ git checkout pull/1550
$ git pull https://git.openjdk.org/jdk11u-dev pull/1550/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1550

View PR using the GUI difftool:
$ git pr show -t 1550

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1550.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 23, 2022

👋 Welcome back Autumn808! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@RealCLanger
Copy link
Contributor

I think you need to remove the word "of" in the PR title to make the bots correctly recognize the backport.

@Autumn808 Autumn808 changed the title Backport of 2b00367e1154feb2c05b84a11d62fb5750e46acf Backport 2b00367e1154feb2c05b84a11d62fb5750e46acf Nov 28, 2022
@Autumn808
Copy link
Contributor Author

I think you need to remove the word "of" in the PR title to make the bots correctly recognize the backport.

Thank you!

@openjdk openjdk bot changed the title Backport 2b00367e1154feb2c05b84a11d62fb5750e46acf 8261350: Create implementation for NSAccessibilityCheckBox protocol peer Nov 28, 2022
@openjdk
Copy link

openjdk bot commented Nov 28, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Nov 28, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 28, 2022

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original commit affected only 5 files, while this PR affects 12. There must be a prior commit to backport first.

@Autumn808 Autumn808 closed this Nov 30, 2022
@Autumn808 Autumn808 deleted the JDK-8261350-hero branch December 1, 2022 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
3 participants