Skip to content

8296496: Overzealous check in sizecalc.h prevents large memory allocation #1551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Nov 24, 2022

Hi all,
This pull request contains a backport of commit 84e12244 from the openjdk/jdk repository.
The commit being backported was authored by Alexander Zuev on 10 Nov 2022 and was reviewed by Alexey Ivanov and Alexander Zvegintsev.
Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8296496: Overzealous check in sizecalc.h prevents large memory allocation

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1551/head:pull/1551
$ git checkout pull/1551

Update a local copy of the PR:
$ git checkout pull/1551
$ git pull https://git.openjdk.org/jdk11u-dev pull/1551/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1551

View PR using the GUI difftool:
$ git pr show -t 1551

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1551.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 24, 2022

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 84e12244a4ff82b3307a5ffe6fbe9dded7b08d86 8296496: Overzealous check in sizecalc.h prevents large memory allocation Nov 24, 2022
@openjdk
Copy link

openjdk bot commented Nov 24, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 24, 2022

@mrserb This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8296496: Overzealous check in sizecalc.h prevents large memory allocation

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 382ac6b: 8297241: Update sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 24, 2022
@mrserb
Copy link
Member Author

mrserb commented Nov 25, 2022

The tier1 test failure is unrelated to this change, see https://bugs.openjdk.org/browse/JDK-8272195

@mrserb mrserb marked this pull request as ready for review November 25, 2022 08:16
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 25, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 25, 2022

Webrevs

@mrserb
Copy link
Member Author

mrserb commented Nov 30, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Nov 30, 2022

Going to push as commit f643709.
Since your change was applied there have been 10 commits pushed to the master branch:

  • 09d50d9: 8222091: Javadoc does not handle package annotations correctly on package-info.java
  • 13bcc23: 8285794: AsyncGetCallTrace might acquire a lock via JavaThread::thread_from_jni_environment
  • b5555c1: 8280863: Update build README to reflect that MSYS2 is supported
  • 178b400: 8295952: Problemlist existing compiler/rtm tests also on x86
  • bc704da: 8268860: Windows-Aarch64 build is failing in GitHub actions
  • af27be3: 8287724: Fix various issues with msys2
  • 99b722d: 8226236: win32: gc/metaspace/TestCapacityUntilGCWrapAround.java fails
  • 7f440c2: 8259485: Document need for short paths when building on Windows
  • 40f4fc2: 8257679: Improved unix compatibility layer in Windows build (winenv)
  • 382ac6b: 8297241: Update sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 30, 2022
@openjdk openjdk bot closed this Nov 30, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 30, 2022
@openjdk
Copy link

openjdk bot commented Nov 30, 2022

@mrserb Pushed as commit f643709.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant