Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8287906: Rewrite of GitHub Actions (GHA) sanity tests #1554

Closed
wants to merge 7 commits into from

Conversation

gdams
Copy link
Member

@gdams gdams commented Nov 25, 2022

The final piece of the puzzle here, backports the GitHub actions rewrite. Also backported JDK-8288499 as it is required for this to be complete.

Clean other than the fact that JDK-8295714 was applied before so had to be rewritten and macOS-10.15 is now deprecated so had to switch to 11 (which had happened already in the old workflow layout.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1554/head:pull/1554
$ git checkout pull/1554

Update a local copy of the PR:
$ git checkout pull/1554
$ git pull https://git.openjdk.org/jdk11u-dev pull/1554/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1554

View PR using the GUI difftool:
$ git pr show -t 1554

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1554.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 25, 2022

👋 Welcome back gdams! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 881ff368ceaff83ae78b1a17896c1ee45524bc84 8287906: Rewrite of GitHub Actions (GHA) sanity tests Nov 25, 2022
@openjdk
Copy link

openjdk bot commented Nov 25, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Nov 25, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 25, 2022

Webrevs

@gdams
Copy link
Member Author

gdams commented Nov 25, 2022

/issue add JDK-8288499

@openjdk
Copy link

openjdk bot commented Nov 25, 2022

@gdams
Adding additional issue to issue list: 8288499: Restore cancel-in-progress in GHA.

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The backport of JDK-8288499, though trivial, should be done separately. You can make that backport dependent on this one, see

https://blog.logrocket.com/using-stacked-pull-requests-in-github/

Copy link
Contributor

@RealCLanger RealCLanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good now!

@openjdk
Copy link

openjdk bot commented Dec 14, 2022

@gdams This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8287906: Rewrite of GitHub Actions (GHA) sanity tests
8288499: Restore cancel-in-progress in GHA

Reviewed-by: phh, clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 12eca2f: 8256126: Create implementation for NSAccessibilityImage protocol peer

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 14, 2022
@RealCLanger
Copy link
Contributor

The backport of JDK-8288499, though trivial, should be done separately.

Hi, @phohensee,
yes, usually that's the process. But I think for this type of little regression fixes, it's ok and pragmatic to do that inline. The Skara bots also help to resolve the JBS items correctly. We've been doing that here and there already and I personally endorse this pattern.

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If that's the policy, lgtm. :)

@gdams
Copy link
Member Author

gdams commented Dec 19, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Dec 19, 2022

Going to push as commit 674218b.
Since your change was applied there have been 5 commits pushed to the master branch:

  • 8a4915e: 8296904: Improve handling of macos xcode toolchain
  • 5f4b38a: 8290899: java/lang/String/StringRepeat.java test requests too much heap on windows x86
  • 3f66b16: 8294580: frame::interpreter_frame_print_on() crashes if free BasicObjectLock exists in frame
  • 01f5a19: 8287011: Improve container information
  • 12eca2f: 8256126: Create implementation for NSAccessibilityImage protocol peer

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 19, 2022
@openjdk openjdk bot closed this Dec 19, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 19, 2022
@openjdk
Copy link

openjdk bot commented Dec 19, 2022

@gdams Pushed as commit 674218b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@gdams gdams deleted the actions branch December 19, 2022 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
3 participants