Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8296957: One more cast in SAFE_SIZE_NEW_ARRAY2 #1556

Closed
wants to merge 3 commits into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Nov 28, 2022

Hi all,
This pull request contains a backport of commit fb6c992f from the openjdk/jdk repository.
The commit being backported was authored by Sergey Bylokhov on 22 Nov 2022 and was reviewed by Alexey Ivanov.
Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1556/head:pull/1556
$ git checkout pull/1556

Update a local copy of the PR:
$ git checkout pull/1556
$ git pull https://git.openjdk.org/jdk11u-dev pull/1556/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1556

View PR using the GUI difftool:
$ git pr show -t 1556

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1556.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 28, 2022

👋 Welcome back serb! A progress list of the required criteria for merging this PR into pr/1551 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport fb6c992f325981c42c7f75109a6c9db7ca8715d8 8296957: One more cast in SAFE_SIZE_NEW_ARRAY2 Nov 28, 2022
@openjdk
Copy link

openjdk bot commented Nov 28, 2022

This backport pull request has now been updated with issue from the original commit.

@mrserb mrserb marked this pull request as ready for review November 28, 2022 10:57
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 28, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 28, 2022

Webrevs

@openjdk-notifier openjdk-notifier bot changed the base branch from pr/1551 to master November 30, 2022 23:14
@openjdk-notifier
Copy link

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout mrserb-backport-fb6c992f
git fetch https://git.openjdk.org/jdk11u-dev master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk openjdk bot removed the clean label Nov 30, 2022
@openjdk openjdk bot added the clean label Dec 1, 2022
@openjdk
Copy link

openjdk bot commented Dec 1, 2022

@mrserb This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8296957: One more cast in SAFE_SIZE_NEW_ARRAY2

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 1, 2022
@mrserb
Copy link
Member Author

mrserb commented Dec 1, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Dec 1, 2022

Going to push as commit 31666ec.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 1, 2022
@openjdk openjdk bot closed this Dec 1, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 1, 2022
@openjdk
Copy link

openjdk bot commented Dec 1, 2022

@mrserb Pushed as commit 31666ec.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant