Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8262981: Create implementation for NSAccessibilitySlider protocol #1561

Closed
wants to merge 7 commits into from

Conversation

Autumn808
Copy link
Contributor

@Autumn808 Autumn808 commented Dec 1, 2022

Backport for JDK-8262981 (https://bugs.openjdk.org/browse/JDK-8262981) this backport is related to backport JDK-8265278 or builds will fail. These backports are a part of a larger series of 28 plus backports JDK-8152350.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8262981: Create implementation for NSAccessibilitySlider protocol

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1561/head:pull/1561
$ git checkout pull/1561

Update a local copy of the PR:
$ git checkout pull/1561
$ git pull https://git.openjdk.org/jdk11u-dev pull/1561/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1561

View PR using the GUI difftool:
$ git pr show -t 1561

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1561.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 1, 2022

👋 Welcome back Autumn808! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 9d669c912d3977027f321a5e6b7f045ca2ce9482 8262981: Create implementation for NSAccessibilitySlider protocol Dec 1, 2022
@openjdk
Copy link

openjdk bot commented Dec 1, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Dec 1, 2022
@mlbridge
Copy link

mlbridge bot commented Dec 1, 2022

Webrevs

@Autumn808 Autumn808 closed this Dec 2, 2022
@Autumn808 Autumn808 deleted the JDK-8262981 branch December 2, 2022 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
1 participant