Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8256108: Create implementation for NSAccessibilityElement protocol peer #1565

Closed
wants to merge 2 commits into from

Conversation

WithEnoughCoffee
Copy link
Contributor

@WithEnoughCoffee WithEnoughCoffee commented Dec 2, 2022

JDK-8256108 part of 28.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8256108: Create implementation for NSAccessibilityElement protocol peer

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1565/head:pull/1565
$ git checkout pull/1565

Update a local copy of the PR:
$ git checkout pull/1565
$ git pull https://git.openjdk.org/jdk11u-dev pull/1565/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1565

View PR using the GUI difftool:
$ git pr show -t 1565

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1565.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 2, 2022

👋 Welcome back Autumn808! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 4c095252a540ea799d6014fb42e6ebedb3b24196 8256108: Create implementation for NSAccessibilityElement protocol peer Dec 2, 2022
@openjdk
Copy link

openjdk bot commented Dec 2, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Dec 2, 2022
@WithEnoughCoffee WithEnoughCoffee deleted the JDK-8256108 branch December 2, 2022 20:19
@WithEnoughCoffee WithEnoughCoffee restored the JDK-8256108 branch December 8, 2022 20:36
@WithEnoughCoffee WithEnoughCoffee marked this pull request as ready for review December 8, 2022 20:37
@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 8, 2022
@mlbridge
Copy link

mlbridge bot commented Dec 8, 2022

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the copyright line update, it's already at 2021 so shouldn't go back to 2020. Otherwise, lgtm.

@WithEnoughCoffee
Copy link
Contributor Author

Please remove the copyright line update, it's already at 2021 so shouldn't go back to 2020. Otherwise, lgtm.

Done. Thank you so much.

@WithEnoughCoffee WithEnoughCoffee deleted the JDK-8256108 branch December 8, 2022 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants