8065422: Trailing dot in hostname causes TLS handshake to fail with SNI disabled

[wkia]

Clean backport

JDK11 has the same issue with processing host names for SNI. It'd be good to keep JDK11 up to date with the upstream. No risks.

Please note that new test added by the change fails for now because of the certs are expired in March, 2022. To fix this, there are additional JDK fixes being backported as dependant PRs

• 8282398: EndingDotHostname.java test fails because SSL cert expired #1575
• 8282511: Use fixed certificate validation date in SSLExampleCert template #1576

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8065422: Trailing dot in hostname causes TLS handshake to fail with SNI disabled

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1574/head:pull/1574
$ git checkout pull/1574

Update a local copy of the PR:
$ git checkout pull/1574
$ git pull https://git.openjdk.org/jdk11u-dev pull/1574/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1574

View PR using the GUI difftool:
$ git pr show -t 1574

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1574.diff

[bridgekeeper]

👋 Welcome back rmarchenko! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

@wkia This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8065422: Trailing dot in hostname causes TLS handshake to fail with SNI disabled

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

• 1acc508: 8274939: Incorrect size of the pixel storage is used by the robot on macOS
• 3990eb2: 8256110: Create implementation for NSAccessibilityStepper protocol
• 674218b: 8287906: Rewrite of GitHub Actions (GHA) sanity tests
• 8a4915e: 8296904: Improve handling of macos xcode toolchain
• 5f4b38a: 8290899: java/lang/String/StringRepeat.java test requests too much heap on windows x86
• 3f66b16: 8294580: frame::interpreter_frame_print_on() crashes if free BasicObjectLock exists in frame
• 01f5a19: 8287011: Improve container information
• 12eca2f: 8256126: Create implementation for NSAccessibilityImage protocol peer
• b3c7b28: 8298459: Fix msys2 linking and handling out of tree build directory for source zip creation
• 604dd4d: 8179317: [TESTBUG] rewrite runtime shell tests in java
• ... and 4 more: https://git.openjdk.org/jdk11u-dev/compare/89f9f91d3a69b473a61d98fab859b751dd6755c2...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[mlbridge]

Webrevs

• 00: Full (7ba456dc)

[GoeLin]

Hi @wkla
please give reason why you backport and assess the risk in the JBS fix request comment.

I remove the fix-request tag in the meantime. Feel free to add again after giving the reason.

[wkia]

Hi @GoeLin
I've updated both the PR and the bug with the reason description and risk assessment.

[wkia]

/integrate

[openjdk]

@wkia
Your change (at version 7ba456d) is now ready to be sponsored by a Committer.

[yan-too]

/sponsor

[openjdk]

Going to push as commit 31b5184.
Since your change was applied there have been 16 commits pushed to the master branch:

• 2a5ae36: 8289695: [TESTBUG] TestMemoryAwareness.java fails on cgroups v2 and crun
• dba3022: 8238936: The crash in XRobotPeer when the custom GraphicsDevice is used
• 1acc508: 8274939: Incorrect size of the pixel storage is used by the robot on macOS
• 3990eb2: 8256110: Create implementation for NSAccessibilityStepper protocol
• 674218b: 8287906: Rewrite of GitHub Actions (GHA) sanity tests
• 8a4915e: 8296904: Improve handling of macos xcode toolchain
• 5f4b38a: 8290899: java/lang/String/StringRepeat.java test requests too much heap on windows x86
• 3f66b16: 8294580: frame::interpreter_frame_print_on() crashes if free BasicObjectLock exists in frame
• 01f5a19: 8287011: Improve container information
• 12eca2f: 8256126: Create implementation for NSAccessibilityImage protocol peer
• ... and 6 more: https://git.openjdk.org/jdk11u-dev/compare/89f9f91d3a69b473a61d98fab859b751dd6755c2...master

Your commit was automatically rebased without conflicts.

[openjdk]

@yan-too @wkia Pushed as commit 31b5184.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.