Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8208227: tools/jdeps/DotFileTest.java fails on Win-X64 #158

Closed

Conversation

@RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Jul 24, 2021

Hi all,

this pull request contains a backport of JDK-8208227 from the openjdk/jdk repository.

The commit being backported was authored by Jonathan Gibbons on 26 Jul 2018 and was reviewed by Joe Darcy.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8208227: tools/jdeps/DotFileTest.java fails on Win-X64

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/158/head:pull/158
$ git checkout pull/158

Update a local copy of the PR:
$ git checkout pull/158
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/158/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 158

View PR using the GUI difftool:
$ git pr show -t 158

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/158.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 24, 2021

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport f0e96435423d8fcbb76dda35f648273ff5780ee3 8208227: tools/jdeps/DotFileTest.java fails on Win-X64 Jul 24, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 24, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Jul 24, 2021

@RealCLanger This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8208227: tools/jdeps/DotFileTest.java fails on Win-X64

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 120 new commits pushed to the master branch:

  • 6762216: 8267666: Add option to jcmd GC.heap_dump to use existing file
  • 63c4ec2: 8259535: ECDSA SignatureValue do not always have the specified length
  • 133eca0: 8235211: serviceability/attach/RemovingUnixDomainSocketTest.java fails with AttachNotSupportedException: Unable to open socket file
  • 7501084: 8268965: TCP Connection Reset when connecting simple socket to SSL server
  • d78e2be: 8227738: jvmti/DataDumpRequest/datadumpreq001 failed due to "exit code is 134"
  • 8637f65: 8227815: Minimal VM: set_state is not a member of AttachListener
  • f3098c4: 8225690: Multiple AttachListener threads can be created
  • 2b3a641: 8245134: test/lib/jdk/test/lib/security/KeyStoreUtils.java should allow to specify aliases
  • 8f49220: 8206350: java/util/Locale/bcp47u/SystemPropertyTests.java failed on Mac 10.13 with zh_CN and zh_TW locales.
  • deba308: 8206083: Make tools/javac/api/T6265137.java robust to JDK version changes
  • ... and 110 more: https://git.openjdk.java.net/jdk11u-dev/compare/f55ef1e033a769101e383792c3964da275fd4582...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 24, 2021

Webrevs

@RealCLanger
Copy link
Contributor Author

@RealCLanger RealCLanger commented Jul 28, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jul 28, 2021

Going to push as commit adcfbd2.
Since your change was applied there have been 128 commits pushed to the master branch:

  • 5c8a0b4: 8207316: java/nio/channels/spi/SelectorProvider/inheritedChannel/InheritedChannelTest.java failed
  • 8ec02f3: 8252648: Shenandoah: name gang tasks consistently
  • eaf59e0: 8256215: Shenandoah: re-organize saving/restoring machine state in assembler code
  • f700d37: 8255255: Update Apache Santuario (XML Signature) to version 2.2.1
  • 227610d: 8267348: Rewrite gc/epsilon/TestClasses.java to use Metaspace with less classes
  • d7a6e51: 8253899: Make IsClassUnloadingEnabled signature match specification
  • 293d44f: 8262017: C2: assert(n != __null) failed: Bad immediate dominator info.
  • 2a3d908: 8269661: JNI_GetStringCritical does not lock char array
  • 6762216: 8267666: Add option to jcmd GC.heap_dump to use existing file
  • 63c4ec2: 8259535: ECDSA SignatureValue do not always have the specified length
  • ... and 118 more: https://git.openjdk.java.net/jdk11u-dev/compare/f55ef1e033a769101e383792c3964da275fd4582...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jul 28, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 28, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 28, 2021

@RealCLanger Pushed as commit adcfbd2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant