8292863: assert(_print_inlining_stream->size() > 0) failed: missing inlining msg

[dhanalla]

assert in print_inlining_update_delayed is checking for an empty inline stream buffer which is expected to be empty.

Fix is to call print_inlining_update_delayed() only when do_late_inline_check() fails in do_late_inline() which is similar to JDK17 code where this issue doesn't reproduce.

Note: This issue is already fixed in JDK17+ branches.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8292863: assert(_print_inlining_stream->size() > 0) failed: missing inlining msg

Reviewers

• Paul Hohensee (@phohensee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1595/head:pull/1595
$ git checkout pull/1595

Update a local copy of the PR:
$ git checkout pull/1595
$ git pull https://git.openjdk.org/jdk11u-dev pull/1595/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1595

View PR using the GUI difftool:
$ git pr show -t 1595

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1595.diff

[bridgekeeper]

👋 Welcome back dhanalla! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 00: Full (06efdc0c)

[phohensee]

Looks like you intended to post a PR against JDK tip, i.e., a commit to your fork of https://github.com/openjdk/jdk.git, not https://github.com/openjdk/jdk11u-dev.

[dhanalla]

Thanks for looking at this PR @phohensee
I am targeting only JDK11 branch as this issue is already fixed in JDK17+ branches.

[phohensee]

You're right! My bad.

[phohensee]

Lgtm.

[openjdk]

@dhanalla This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8292863: assert(_print_inlining_stream->size() > 0) failed: missing inlining msg

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

• 3f66b16: 8294580: frame::interpreter_frame_print_on() crashes if free BasicObjectLock exists in frame
• 01f5a19: 8287011: Improve container information

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[dhanalla]

Lgtm.
Thanks for the review @phohensee

[dhanalla]

/integrate

[openjdk]

@dhanalla
Your change (at version 06efdc0) is now ready to be sponsored by a Committer.

[RealCLanger]

@dhanalla For JDK Updates projects, it's not sufficient to get a PR reviewed but you also need maintainer approval. This can be requested by adding the label jdk11u-fix-request to the JBS bug and adding some request comment, why you want to get this backport/patch in, the risk involved, the testing done etc. Please do so, or, if you don't have a JBS account, please post the request comment here and I can post it in JBS on your behalf.

You find a more detailed process description here

Furthermore, please enable Github Actions on your repository and run the tests to get some basic verification of your patch.

Thanks!

[dhanalla]

Thanks @RealCLanger,
we have updated the bug with label, reason for fix, risk and test details.

[RealCLanger]

Thanks @RealCLanger, we have updated the bug with label, reason for fix, risk and test details.

great, thanks. It has approvel now, so I sponsor it.

/sponsor

[openjdk]

Going to push as commit 06f769a.
Since your change was applied there have been 50 commits pushed to the master branch:

• 1d78ce4: 8221351: Crash in KlassFactory::check_shared_class_file_load_hook
• 3c2763f: 8195716: BootstrapLoggerTest : Executor still alive
• decfc86: 8217353: java/util/logging/LogManager/Configuration/updateConfiguration/HandlersOnComplexResetUpdate.java fails with Unexpected reference: java.lang.ref.WeakReference
• dc5590f: 8213932: [TESTBUG] assertEquals is invoked with the arguments in the wrong order
• 1713cf1: 8215759: [test] java/math/BigInteger/ModPow.java can throw an ArithmeticException
• 13eadde: 8215372: test/jdk/java/nio/file/DirectoryStream/Basic.java not correct when using a glob
• ff60b34: 8296239: ISO 4217 Amendment 174 Update
• 6073296: 8299616: [11u] Bootcycle build fails after JDK-8257679 backport
• 52737cd: 8280401: [sspi] gss_accept_sec_context leaves output_token uninitialized
• d8450ef: 8271506: Add ResourceHashtable support for deleting selected entries
• ... and 40 more: https://git.openjdk.org/jdk11u-dev/compare/12eca2f8ac6e8127f1d698aef50db03cf278a7b8...master

Your commit was automatically rebased without conflicts.

[openjdk]

@RealCLanger @dhanalla Pushed as commit 06f769a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.