8256240: Reproducible builds should turn on the "deterministic" flag for Visual Studio

[RealCLanger]

This is the backport of JDK-8256240. I incorporated JDK-8281262 because the code that was removed by it in flags-cflags.m4 did not work in 11u-dev due to some missing requirements. I will hence mark JDK-8281262 as fixed by this change.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issues

• JDK-8256240: Reproducible builds should turn on the "deterministic" flag for Visual Studio
• JDK-8281262: Windows builds in different directories are not fully reproducible

Reviewers

• Paul Hohensee (@phohensee - Reviewer) ⚠️ Review applies to 33d5caf9

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1598/head:pull/1598
$ git checkout pull/1598

Update a local copy of the PR:
$ git checkout pull/1598
$ git pull https://git.openjdk.org/jdk11u-dev pull/1598/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1598

View PR using the GUI difftool:
$ git pr show -t 1598

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1598.diff

[bridgekeeper]

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into pr/1597 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[RealCLanger]

/issue add 8281262

[openjdk]

@RealCLanger
Adding additional issue to issue list: 8281262: Windows builds in different directories are not fully reproducible.

[mlbridge]

Webrevs

• 02: Full - Incremental (5c399661)
• 01: Full - Incremental (33d5caf9)
• 00: Full (33d5caf9)

[phohensee]

Lgtm.

[openjdk-notifier]

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout JDK-8256240
git fetch https://git.openjdk.org/jdk11u-dev master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

[openjdk]

@RealCLanger This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8256240: Reproducible builds should turn on the "deterministic" flag for Visual Studio
8281262: Windows builds in different directories are not fully reproducible

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[RealCLanger]

/integrate

[openjdk]

Going to push as commit bcda041.

[openjdk]

@RealCLanger Pushed as commit bcda041.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.