Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8274939: Incorrect size of the pixel storage is used by the robot on macOS #1600

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Dec 17, 2022

Hi all,
This pull request contains a backport of commit eff5dafb from the openjdk/jdk repository.
The commit being backported was authored by Sergey Bylokhov on 12 Feb 2022 and was reviewed by Alexey Ivanov and Phil Race.

The change is not clean because of the context difference caused by the missing JDK-8211300 in jdk11u-dev.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8274939: Incorrect size of the pixel storage is used by the robot on macOS

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1600/head:pull/1600
$ git checkout pull/1600

Update a local copy of the PR:
$ git checkout pull/1600
$ git pull https://git.openjdk.org/jdk11u-dev pull/1600/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1600

View PR using the GUI difftool:
$ git pr show -t 1600

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1600.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 17, 2022

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport eff5dafba9f72bd0612357712ffa472ce1c9166a 8274939: Incorrect size of the pixel storage is used by the robot on macOS Dec 17, 2022
@openjdk
Copy link

openjdk bot commented Dec 17, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Dec 17, 2022
@mrserb mrserb marked this pull request as ready for review December 18, 2022 01:58
@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 18, 2022
@mlbridge
Copy link

mlbridge bot commented Dec 18, 2022

Webrevs

@RealCLanger
Copy link
Contributor

You could have used /clean on that one, I guess 😉

@openjdk
Copy link

openjdk bot commented Dec 19, 2022

@mrserb This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8274939: Incorrect size of the pixel storage is used by the robot on macOS

Reviewed-by: clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

  • 3990eb2: 8256110: Create implementation for NSAccessibilityStepper protocol
  • 674218b: 8287906: Rewrite of GitHub Actions (GHA) sanity tests
  • 8a4915e: 8296904: Improve handling of macos xcode toolchain
  • 5f4b38a: 8290899: java/lang/String/StringRepeat.java test requests too much heap on windows x86
  • 3f66b16: 8294580: frame::interpreter_frame_print_on() crashes if free BasicObjectLock exists in frame
  • 01f5a19: 8287011: Improve container information
  • 12eca2f: 8256126: Create implementation for NSAccessibilityImage protocol peer
  • b3c7b28: 8298459: Fix msys2 linking and handling out of tree build directory for source zip creation
  • 604dd4d: 8179317: [TESTBUG] rewrite runtime shell tests in java
  • 7d50d51: 8259267: Refactor LoaderLeak shell test as java test.
  • ... and 2 more: https://git.openjdk.org/jdk11u-dev/compare/9197181f4e3e1e000879541678aa7659928da410...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 19, 2022
@mrserb
Copy link
Member Author

mrserb commented Dec 20, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Dec 20, 2022

Going to push as commit 1acc508.
Since your change was applied there have been 12 commits pushed to the master branch:

  • 3990eb2: 8256110: Create implementation for NSAccessibilityStepper protocol
  • 674218b: 8287906: Rewrite of GitHub Actions (GHA) sanity tests
  • 8a4915e: 8296904: Improve handling of macos xcode toolchain
  • 5f4b38a: 8290899: java/lang/String/StringRepeat.java test requests too much heap on windows x86
  • 3f66b16: 8294580: frame::interpreter_frame_print_on() crashes if free BasicObjectLock exists in frame
  • 01f5a19: 8287011: Improve container information
  • 12eca2f: 8256126: Create implementation for NSAccessibilityImage protocol peer
  • b3c7b28: 8298459: Fix msys2 linking and handling out of tree build directory for source zip creation
  • 604dd4d: 8179317: [TESTBUG] rewrite runtime shell tests in java
  • 7d50d51: 8259267: Refactor LoaderLeak shell test as java test.
  • ... and 2 more: https://git.openjdk.org/jdk11u-dev/compare/9197181f4e3e1e000879541678aa7659928da410...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 20, 2022
@openjdk openjdk bot closed this Dec 20, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 20, 2022
@openjdk
Copy link

openjdk bot commented Dec 20, 2022

@mrserb Pushed as commit 1acc508.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mrserb mrserb deleted the mrserb-backport-eff5dafb branch December 20, 2022 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants