Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8298108: Add a regression test for JDK-8297684 #1608

Closed
wants to merge 1 commit into from

Conversation

jerboaa
Copy link
Contributor

@jerboaa jerboaa commented Dec 23, 2022

Clean backport. Adds another reg-test for the issue fixed with openjdk/jdk11u#65 Fails without the fix, passes with it.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1608/head:pull/1608
$ git checkout pull/1608

Update a local copy of the PR:
$ git checkout pull/1608
$ git pull https://git.openjdk.org/jdk11u-dev pull/1608/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1608

View PR using the GUI difftool:
$ git pr show -t 1608

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1608.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 23, 2022

👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 4da8411674b7515310000bd8243860bc73f9a03d 8298108: Add a regression test for JDK-8297684 Dec 23, 2022
@openjdk
Copy link

openjdk bot commented Dec 23, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Dec 23, 2022

@jerboaa This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8298108: Add a regression test for JDK-8297684

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 23, 2022
@mlbridge
Copy link

mlbridge bot commented Dec 23, 2022

Webrevs

@jerboaa
Copy link
Contributor Author

jerboaa commented Jan 10, 2023

Windows test failure java/util/DoubleStreamSums/CompensatedSums seems unrelated.

@jerboaa
Copy link
Contributor Author

jerboaa commented Jan 10, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Jan 10, 2023

Going to push as commit 03555b1.
Since your change was applied there have been 36 commits pushed to the master branch:

  • ca23550: 8295412: support latest VS2022 MSC_VER in abstract_vm_version.cpp
  • e92b7c3: 8290964: C2 compilation fails with assert "non-reduction loop contains reduction nodes"
  • 369dedb: 8293996: C2: fix and simplify IdealLoopTree::do_remove_empty_loop
  • 80eecc5: 8299439: java/text/Format/NumberFormat/CurrencyFormat.java fails for hr_HR
  • dfcf7c1: 8256111: Create implementation for NSAccessibilityStaticText protocol
  • 06f769a: 8292863: assert(_print_inlining_stream->size() > 0) failed: missing inlining msg
  • 1d78ce4: 8221351: Crash in KlassFactory::check_shared_class_file_load_hook
  • 3c2763f: 8195716: BootstrapLoggerTest : Executor still alive
  • decfc86: 8217353: java/util/logging/LogManager/Configuration/updateConfiguration/HandlersOnComplexResetUpdate.java fails with Unexpected reference: java.lang.ref.WeakReference
  • dc5590f: 8213932: [TESTBUG] assertEquals is invoked with the arguments in the wrong order
  • ... and 26 more: https://git.openjdk.org/jdk11u-dev/compare/ca49dbf39916e4d68e81e139a14d922f6144e8ee...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 10, 2023
@openjdk openjdk bot closed this Jan 10, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 10, 2023
@openjdk
Copy link

openjdk bot commented Jan 10, 2023

@jerboaa Pushed as commit 03555b1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant