Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8299445: EndingDotHostname.java fails because of compilation errors #1626

Closed
wants to merge 1 commit into from

Conversation

wkia
Copy link

@wkia wkia commented Jan 2, 2023

The test fails because of compilation errors - the test uses jdk17 strings, they were not adapted for jdk11 when backported.
This fix uses approptiate string creation approach.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8299445: EndingDotHostname.java fails because of compilation errors

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1626/head:pull/1626
$ git checkout pull/1626

Update a local copy of the PR:
$ git checkout pull/1626
$ git pull https://git.openjdk.org/jdk11u-dev pull/1626/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1626

View PR using the GUI difftool:
$ git pr show -t 1626

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1626.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 2, 2023

👋 Welcome back rmarchenko! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 2, 2023
@mlbridge
Copy link

mlbridge bot commented Jan 2, 2023

Webrevs

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing!

@openjdk
Copy link

openjdk bot commented Jan 2, 2023

@wkia This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8299445: EndingDotHostname.java fails because of compilation errors

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

  • f6aef8a: 8065097: [macosx] javax/swing/Popup/TaskbarPositionTest.java fails because Popup is one pixel off
  • d1f6bd1: 8285399: JNI exception pending in awt_GraphicsEnv.c:1432
  • c898a3e: 8284023: java.sun.awt.X11GraphicsDevice.getDoubleBufferVisuals() leaks XdbeScreenVisualInfo
  • 5971a6a: 8280391: NMT: Correct NMT tag on CollectedHeap
  • 984e456: 8256934: C2: assert(C->live_nodes() <= C->max_node_limit()) failed: Live Node limit exceeded limit
  • d52365e: 8230731: SA tests fail with "Windbg Error: ReadVirtual failed"
  • ffc2ced: 8212216: JGSS: Fix leak in exception cases in getJavaOID()
  • 4c2ff08: 8212165: JGSS: Fix cut/paste error in NativeUtil.c

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@TheRealMDoerr) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 2, 2023
@wkia
Copy link
Author

wkia commented Jan 2, 2023

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jan 2, 2023
@openjdk
Copy link

openjdk bot commented Jan 2, 2023

@wkia
Your change (at version e26ce69) is now ready to be sponsored by a Committer.

@TheRealMDoerr
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Jan 3, 2023

Going to push as commit f9f3fcb.
Since your change was applied there have been 8 commits pushed to the master branch:

  • f6aef8a: 8065097: [macosx] javax/swing/Popup/TaskbarPositionTest.java fails because Popup is one pixel off
  • d1f6bd1: 8285399: JNI exception pending in awt_GraphicsEnv.c:1432
  • c898a3e: 8284023: java.sun.awt.X11GraphicsDevice.getDoubleBufferVisuals() leaks XdbeScreenVisualInfo
  • 5971a6a: 8280391: NMT: Correct NMT tag on CollectedHeap
  • 984e456: 8256934: C2: assert(C->live_nodes() <= C->max_node_limit()) failed: Live Node limit exceeded limit
  • d52365e: 8230731: SA tests fail with "Windbg Error: ReadVirtual failed"
  • ffc2ced: 8212216: JGSS: Fix leak in exception cases in getJavaOID()
  • 4c2ff08: 8212165: JGSS: Fix cut/paste error in NativeUtil.c

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 3, 2023
@openjdk openjdk bot closed this Jan 3, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jan 3, 2023
@openjdk
Copy link

openjdk bot commented Jan 3, 2023

@TheRealMDoerr @wkia Pushed as commit f9f3fcb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@wkia wkia deleted the endingdothostname-fix branch February 15, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants