Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8195716: BootstrapLoggerTest : Executor still alive #1635

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jan 3, 2023

I backport this for parity with 11.0.19-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8195716: BootstrapLoggerTest : Executor still alive

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1635/head:pull/1635
$ git checkout pull/1635

Update a local copy of the PR:
$ git checkout pull/1635
$ git pull https://git.openjdk.org/jdk11u-dev pull/1635/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1635

View PR using the GUI difftool:
$ git pr show -t 1635

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1635.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 3, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 2aace6bd9767c9ad91a9f273bd28165169194d93 8195716: BootstrapLoggerTest : Executor still alive Jan 3, 2023
@openjdk
Copy link

openjdk bot commented Jan 3, 2023

This backport pull request has now been updated with issue and summary from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 3, 2023

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8195716: BootstrapLoggerTest : Executor still alive

Make sure the test joins the active executor thread before waiting for the executor to be GC'ed.

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 3, 2023
@mlbridge
Copy link

mlbridge bot commented Jan 3, 2023

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Jan 5, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Jan 5, 2023

Going to push as commit 3c2763f.
Since your change was applied there have been 9 commits pushed to the master branch:

  • decfc86: 8217353: java/util/logging/LogManager/Configuration/updateConfiguration/HandlersOnComplexResetUpdate.java fails with Unexpected reference: java.lang.ref.WeakReference
  • dc5590f: 8213932: [TESTBUG] assertEquals is invoked with the arguments in the wrong order
  • 1713cf1: 8215759: [test] java/math/BigInteger/ModPow.java can throw an ArithmeticException
  • 13eadde: 8215372: test/jdk/java/nio/file/DirectoryStream/Basic.java not correct when using a glob
  • ff60b34: 8296239: ISO 4217 Amendment 174 Update
  • 6073296: 8299616: [11u] Bootcycle build fails after JDK-8257679 backport
  • 52737cd: 8280401: [sspi] gss_accept_sec_context leaves output_token uninitialized
  • d8450ef: 8271506: Add ResourceHashtable support for deleting selected entries
  • d2c8326: 8210373: Deadlock in libj2gss.so when loading "j2gss" and "net" libraries in parallel.

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 5, 2023
@openjdk openjdk bot closed this Jan 5, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 5, 2023
@openjdk
Copy link

openjdk bot commented Jan 5, 2023

@GoeLin Pushed as commit 3c2763f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant