Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8261350: Create implementation for NSAccessibilityCheckBox protocol peer #1646

Closed
wants to merge 1 commit into from

Conversation

Autumn808
Copy link
Contributor

@Autumn808 Autumn808 commented Jan 12, 2023

JDK-8261350 Clean Backport. One of a series of 28 https://bugs.openjdk.org/browse/JDK-8152350


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8261350: Create implementation for NSAccessibilityCheckBox protocol peer

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1646/head:pull/1646
$ git checkout pull/1646

Update a local copy of the PR:
$ git checkout pull/1646
$ git pull https://git.openjdk.org/jdk11u-dev pull/1646/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1646

View PR using the GUI difftool:
$ git pr show -t 1646

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1646.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 12, 2023

👋 Welcome back Autumn808! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 2b00367e1154feb2c05b84a11d62fb5750e46acf 8261350: Create implementation for NSAccessibilityCheckBox protocol peer Jan 12, 2023
@openjdk
Copy link

openjdk bot commented Jan 12, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 12, 2023

@Autumn808 This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8261350: Create implementation for NSAccessibilityCheckBox protocol peer

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

  • 8dd8122: 8296924: C2: assert(is_valid_AArch64_address(dest.target())) failed: bad address
  • 6c3d4df: 8283719: java/util/logging/CheckZombieLockTest.java failing intermittently
  • b52d8ad: 8283717: vmTestbase/nsk/jdi/ThreadStartEvent/thread/thread001 failed due to SocketTimeoutException
  • 9c684a1: 8294947: Use 64bit atomics in patch_verified_entry on x86_64
  • 71e89e1: 8297569: URLPermission constructor throws IllegalArgumentException: Invalid characters in hostname after JDK-8294378
  • 8458368: 8294378: URLPermission constructor exception when using tr locale
  • 6faa77c: 8285835: SIGSEGV in PhaseIdealLoop::build_loop_late_post_work
  • c20794c: 8267038: Update IANA Language Subtag Registry to Version 2022-03-02
  • 466edc0: 8214445: [test] java/net/URL/HandlerLoop has illegal reflective access
  • 7bbb6ba: 8299789: Compilation of gtest causes build to fail if runtime libraries are in different dirs
  • ... and 1 more: https://git.openjdk.org/jdk11u-dev/compare/ba60e61ca2f163367dbdce5248a8e456da76efd8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 12, 2023
@mlbridge
Copy link

mlbridge bot commented Jan 12, 2023

Webrevs

@phohensee
Copy link
Member

Tagged the JBS issue.

@Autumn808
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jan 17, 2023
@openjdk
Copy link

openjdk bot commented Jan 17, 2023

@Autumn808
Your change (at version 26e8ccd) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Jan 17, 2023

Going to push as commit 15cb63e.
Since your change was applied there have been 11 commits pushed to the master branch:

  • 8dd8122: 8296924: C2: assert(is_valid_AArch64_address(dest.target())) failed: bad address
  • 6c3d4df: 8283719: java/util/logging/CheckZombieLockTest.java failing intermittently
  • b52d8ad: 8283717: vmTestbase/nsk/jdi/ThreadStartEvent/thread/thread001 failed due to SocketTimeoutException
  • 9c684a1: 8294947: Use 64bit atomics in patch_verified_entry on x86_64
  • 71e89e1: 8297569: URLPermission constructor throws IllegalArgumentException: Invalid characters in hostname after JDK-8294378
  • 8458368: 8294378: URLPermission constructor exception when using tr locale
  • 6faa77c: 8285835: SIGSEGV in PhaseIdealLoop::build_loop_late_post_work
  • c20794c: 8267038: Update IANA Language Subtag Registry to Version 2022-03-02
  • 466edc0: 8214445: [test] java/net/URL/HandlerLoop has illegal reflective access
  • 7bbb6ba: 8299789: Compilation of gtest causes build to fail if runtime libraries are in different dirs
  • ... and 1 more: https://git.openjdk.org/jdk11u-dev/compare/ba60e61ca2f163367dbdce5248a8e456da76efd8...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 17, 2023
@openjdk openjdk bot closed this Jan 17, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jan 17, 2023
@openjdk
Copy link

openjdk bot commented Jan 17, 2023

@phohensee @Autumn808 Pushed as commit 15cb63e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants