-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8285835: SIGSEGV in PhaseIdealLoop::build_loop_late_post_work #1649
Conversation
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test is missing, otherwise fine.
Thanks catching this. Forgotten again. |
@GoeLin This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
Pre-submit tests: all the x86/64 builds access the same unavailable resouce: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm now.
/nitegrate |
@GoeLin Unknown command |
/integrate |
Going to push as commit 6faa77c.
Your commit was automatically rebased without conflicts. |
I backport this for parity with 11.0.19-oracle.
I resolved one chunk in escape.cpp because
non_escaped_worklist has been renamed in 17 to
non_escaped_allocs_worklist by "8263989: Cleanup in EA"
Might end up being clean.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1649/head:pull/1649
$ git checkout pull/1649
Update a local copy of the PR:
$ git checkout pull/1649
$ git pull https://git.openjdk.org/jdk11u-dev pull/1649/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1649
View PR using the GUI difftool:
$ git pr show -t 1649
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1649.diff