Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8285835: SIGSEGV in PhaseIdealLoop::build_loop_late_post_work #1649

Closed
wants to merge 3 commits into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jan 12, 2023

I backport this for parity with 11.0.19-oracle.

I resolved one chunk in escape.cpp because
non_escaped_worklist has been renamed in 17 to
non_escaped_allocs_worklist by "8263989: Cleanup in EA"
Might end up being clean.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8285835: SIGSEGV in PhaseIdealLoop::build_loop_late_post_work

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1649/head:pull/1649
$ git checkout pull/1649

Update a local copy of the PR:
$ git checkout pull/1649
$ git pull https://git.openjdk.org/jdk11u-dev pull/1649/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1649

View PR using the GUI difftool:
$ git pr show -t 1649

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1649.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 12, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 3e7f840859d9081fc6cf1086bda75fa5aa76a4e9 8285835: SIGSEGV in PhaseIdealLoop::build_loop_late_post_work Jan 12, 2023
@openjdk
Copy link

openjdk bot commented Jan 12, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jan 12, 2023
@mlbridge
Copy link

mlbridge bot commented Jan 12, 2023

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test is missing, otherwise fine.

@GoeLin
Copy link
Member Author

GoeLin commented Jan 13, 2023

Thanks catching this. Forgotten again.

@openjdk openjdk bot added the clean label Jan 13, 2023
@openjdk
Copy link

openjdk bot commented Jan 13, 2023

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8285835: SIGSEGV in PhaseIdealLoop::build_loop_late_post_work

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 13, 2023
@GoeLin
Copy link
Member Author

GoeLin commented Jan 13, 2023

Pre-submit tests: all the x86/64 builds access the same unavailable resouce:
Unable to connect to azure.archive.ubuntu.com

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm now.

@GoeLin
Copy link
Member Author

GoeLin commented Jan 16, 2023

/nitegrate

@openjdk
Copy link

openjdk bot commented Jan 16, 2023

@GoeLin Unknown command nitegrate - for a list of valid commands use /help.

@GoeLin
Copy link
Member Author

GoeLin commented Jan 16, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Jan 16, 2023

Going to push as commit 6faa77c.
Since your change was applied there have been 2 commits pushed to the master branch:

  • c20794c: 8267038: Update IANA Language Subtag Registry to Version 2022-03-02
  • 466edc0: 8214445: [test] java/net/URL/HandlerLoop has illegal reflective access

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 16, 2023
@openjdk openjdk bot closed this Jan 16, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 16, 2023
@openjdk
Copy link

openjdk bot commented Jan 16, 2023

@GoeLin Pushed as commit 6faa77c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8285835 branch January 16, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants