Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8209773: Refactor shell test javax/naming/module/basic.sh to java #165

Closed

Conversation

@RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Jul 26, 2021

Hi all,

this pull request contains a backport of JDK-8209773 from the openjdk/jdk repository.

The commit being backported was authored by Chris Yin on 11 Sep 2018 and was reviewed by Vyom Tewari and Alan Bateman.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8209773: Refactor shell test javax/naming/module/basic.sh to java

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/165/head:pull/165
$ git checkout pull/165

Update a local copy of the PR:
$ git checkout pull/165
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/165/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 165

View PR using the GUI difftool:
$ git pr show -t 165

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/165.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 26, 2021

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 694380add3c4fc4fef20ecd0a83847cfbc7aa57c 8209773: Refactor shell test javax/naming/module/basic.sh to java Jul 26, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 26, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Jul 26, 2021

@RealCLanger This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8209773: Refactor shell test javax/naming/module/basic.sh to java

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 69 new commits pushed to the master branch:

  • 2a3d908: 8269661: JNI_GetStringCritical does not lock char array
  • 6762216: 8267666: Add option to jcmd GC.heap_dump to use existing file
  • 63c4ec2: 8259535: ECDSA SignatureValue do not always have the specified length
  • 133eca0: 8235211: serviceability/attach/RemovingUnixDomainSocketTest.java fails with AttachNotSupportedException: Unable to open socket file
  • 7501084: 8268965: TCP Connection Reset when connecting simple socket to SSL server
  • d78e2be: 8227738: jvmti/DataDumpRequest/datadumpreq001 failed due to "exit code is 134"
  • 8637f65: 8227815: Minimal VM: set_state is not a member of AttachListener
  • f3098c4: 8225690: Multiple AttachListener threads can be created
  • 2b3a641: 8245134: test/lib/jdk/test/lib/security/KeyStoreUtils.java should allow to specify aliases
  • 8f49220: 8206350: java/util/Locale/bcp47u/SystemPropertyTests.java failed on Mac 10.13 with zh_CN and zh_TW locales.
  • ... and 59 more: https://git.openjdk.java.net/jdk11u-dev/compare/73e987c317d9d96a3a309312a2fd9b1b8f779dcb...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 26, 2021

Webrevs

@RealCLanger
Copy link
Contributor Author

@RealCLanger RealCLanger commented Jul 28, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jul 28, 2021

Going to push as commit 95c94ae.
Since your change was applied there have been 82 commits pushed to the master branch:

  • d7e852c: 8209930: Refactor java/util/zip/ZipFile/deletetempjar.sh to plain java test
  • bb15820: 8042902: Test java/net/Inet6Address/serialize/Inet6AddressSerializationTest.java fails intermittently
  • 69341be: 8261147: C2: Node is wrongly marked as reduction resulting in a wrong execution due to wrong vector instructions
  • feee8ef: 8209832: Refactor jdk/internal/reflect/Reflection/GetCallerClassTest.sh to plain java test
  • 57a7e71: 8194230: jdk/internal/jrtfs/remote/RemoteRuntimeImageTest.java fails with java.lang.NullPointerException
  • adcfbd2: 8208227: tools/jdeps/DotFileTest.java fails on Win-X64
  • 5c8a0b4: 8207316: java/nio/channels/spi/SelectorProvider/inheritedChannel/InheritedChannelTest.java failed
  • 8ec02f3: 8252648: Shenandoah: name gang tasks consistently
  • eaf59e0: 8256215: Shenandoah: re-organize saving/restoring machine state in assembler code
  • f700d37: 8255255: Update Apache Santuario (XML Signature) to version 2.2.1
  • ... and 72 more: https://git.openjdk.java.net/jdk11u-dev/compare/73e987c317d9d96a3a309312a2fd9b1b8f779dcb...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jul 28, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 28, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 28, 2021

@RealCLanger Pushed as commit 95c94ae.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RealCLanger
Copy link
Contributor Author

@RealCLanger RealCLanger commented Jul 28, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jul 28, 2021

@RealCLanger The command integrate can only be used in open pull requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant