Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8296912: C2: CreateExNode::Identity fails with assert(i < _max) failed: oob: i=1, _max=1 #1657

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jan 16, 2023

I backport this for parity with 11.0.19-oracle.

I had to resolve the test @run description because -XX:+StresssIGVN is not in 11.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8296912: C2: CreateExNode::Identity fails with assert(i < _max) failed: oob: i=1, _max=1

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1657/head:pull/1657
$ git checkout pull/1657

Update a local copy of the PR:
$ git checkout pull/1657
$ git pull https://git.openjdk.org/jdk11u-dev pull/1657/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1657

View PR using the GUI difftool:
$ git pr show -t 1657

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1657.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 16, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 502fa3eeea849cfcc50436602be1654695ef4e26 8296912: C2: CreateExNode::Identity fails with assert(i < _max) failed: oob: i=1, _max=1 Jan 16, 2023
@openjdk
Copy link

openjdk bot commented Jan 16, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jan 16, 2023
@mlbridge
Copy link

mlbridge bot commented Jan 16, 2023

Webrevs

Copy link
Member

@reinrich reinrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Thanks, Richard.

@openjdk
Copy link

openjdk bot commented Jan 18, 2023

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8296912: C2: CreateExNode::Identity fails with assert(i < _max) failed: oob: i=1, _max=1

Reviewed-by: rrich

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

  • 465b4f2: 8298093: improve cleanup and error handling of awt_parseColorModel in awt_parseImage.c
  • 014c5ae: 8297480: GetPrimitiveArrayCritical in imageioJPEG misses result - NULL check
  • edf4fb0: 8295211: Fix autoconf 2.71 warning "AC_CHECK_HEADERS: you should use literals"
  • 15cb63e: 8261350: Create implementation for NSAccessibilityCheckBox protocol peer
  • 8dd8122: 8296924: C2: assert(is_valid_AArch64_address(dest.target())) failed: bad address
  • 6c3d4df: 8283719: java/util/logging/CheckZombieLockTest.java failing intermittently
  • b52d8ad: 8283717: vmTestbase/nsk/jdi/ThreadStartEvent/thread/thread001 failed due to SocketTimeoutException
  • 9c684a1: 8294947: Use 64bit atomics in patch_verified_entry on x86_64
  • 71e89e1: 8297569: URLPermission constructor throws IllegalArgumentException: Invalid characters in hostname after JDK-8294378
  • 8458368: 8294378: URLPermission constructor exception when using tr locale
  • ... and 3 more: https://git.openjdk.org/jdk11u-dev/compare/7bbb6ba0c8e32d13db3350778c4e5ab00abb020d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 18, 2023
@GoeLin
Copy link
Member Author

GoeLin commented Feb 8, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Feb 8, 2023

Going to push as commit 9d7bb60.
Since your change was applied there have been 67 commits pushed to the master branch:

  • 65180f1: 8290920: sspi_bridge.dll not built if BUILD_CRYPTO is false
  • 7e74421: 8286962: java/net/httpclient/ServerCloseTest.java failed once with ConnectException
  • ebac392: 8300742: jstat's CGCT is 5 percent higher than the pause time in -Xlog:gc.
  • fc4b9de: 8218431: Improved platform checking in makefiles
  • 6ffd006: 8241806: The sun/awt/shell/FileSystemViewMemoryLeak.java is unstable
  • f5a04fb: 8299194: CustomTzIDCheckDST.java may fail at future date
  • acedbcb: 8299296: Write a test to verify the components selection sends ItemEvent
  • 37a15a1: 8286800: Assert in PhaseIdealLoop::dump_real_LCA is too strong
  • 8547c80: 8300773: Address the inconsistency between the constant array and pool size
  • b10ad19: 8282036: Change java/util/zip/ZipFile/DeleteTempJar.java to stop HttpServer cleanly in case of exceptions
  • ... and 57 more: https://git.openjdk.org/jdk11u-dev/compare/7bbb6ba0c8e32d13db3350778c4e5ab00abb020d...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 8, 2023
@openjdk openjdk bot closed this Feb 8, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 8, 2023
@GoeLin GoeLin deleted the goetz_backport_8296912 branch February 8, 2023 16:06
@openjdk
Copy link

openjdk bot commented Feb 8, 2023

@GoeLin Pushed as commit 9d7bb60.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants