Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8295788: C2 compilation hits "assert((mode == ControlAroundStripMined && use == sfpt) || !use->is_reachable_from_root()) failed: missed a node" #1658

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jan 16, 2023

I backport this for parity with 11.0.19-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8295788: C2 compilation hits "assert((mode == ControlAroundStripMined && use == sfpt) || !use->is_reachable_from_root()) failed: missed a node"

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1658/head:pull/1658
$ git checkout pull/1658

Update a local copy of the PR:
$ git checkout pull/1658
$ git pull https://git.openjdk.org/jdk11u-dev pull/1658/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1658

View PR using the GUI difftool:
$ git pr show -t 1658

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1658.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 16, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 761a4f4852cbb40660b6fb9eda4d740464218f75 8295788: C2 compilation hits "assert((mode == ControlAroundStripMined && use == sfpt) || !use->is_reachable_from_root()) failed: missed a node" Jan 16, 2023
@openjdk
Copy link

openjdk bot commented Jan 16, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 16, 2023

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8295788: C2 compilation hits "assert((mode == ControlAroundStripMined && use == sfpt) || !use->is_reachable_from_root()) failed: missed a node"

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 16, 2023
@mlbridge
Copy link

mlbridge bot commented Jan 16, 2023

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Jan 25, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Jan 25, 2023

Going to push as commit 9ef11ac.
Since your change was applied there have been 40 commits pushed to the master branch:

  • f999efd: 8287180: Update IANA Language Subtag Registry to Version 2022-08-08
  • d1fb7b2: 8285690: CloneableReference subtest should not throw CloneNotSupportedException
  • f4c5bdf: 8272985: Reference discovery is confused about atomicity and degree of parallelism
  • e4fdd03: 8209115: adjust libsplashscreen linux ppc64le builds for easier libpng update
  • c9ce60b: 8261352: Create implementation for component peer for all the components who should be ignored in a11y interactions
  • 0422f05: 8300642: [17u,11u] Fix DEFAULT_PROMOTED_VERSION_PRE=ea for -dev
  • f4eccbe: 8296619: Upgrade jQuery to 3.6.1
  • 01b2138: 8297088: Update LCMS to 2.14
  • 972ff6f: 8280896: java/nio/file/Files/probeContentType/Basic.java fails on Windows 11
  • ee89e43: Merge
  • ... and 30 more: https://git.openjdk.org/jdk11u-dev/compare/7bbb6ba0c8e32d13db3350778c4e5ab00abb020d...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 25, 2023
@openjdk openjdk bot closed this Jan 25, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 25, 2023
@openjdk
Copy link

openjdk bot commented Jan 25, 2023

@GoeLin Pushed as commit 9ef11ac.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant