-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8297088: Update LCMS to 2.14 #1659
Conversation
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
@GoeLin This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 7 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 01b2138.
Your commit was automatically rebased without conflicts. |
I backport this for parity with 11.0.19-oracle.
I had to resolve cmsio0.c because "8273135: java/awt/color/ICC_ColorSpace/MTTransformReplacedProfile.java crashes"
is not in 11. I checked whether backporting that
change make sense. But that change again depends on
"8271718: Crash when during color transformation the color profile is replaced"
which is hard to backport because "8263482: Make access to the ICC color profiles data multithread-friendly"
is not in 11. This again is not good for backporting.
So I rather did the simple resolve. This required change should not wait for eventual complicated other backports.
Anyways, it might end up being marked as clean.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1659/head:pull/1659
$ git checkout pull/1659
Update a local copy of the PR:
$ git checkout pull/1659
$ git pull https://git.openjdk.org/jdk11u-dev pull/1659/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1659
View PR using the GUI difftool:
$ git pr show -t 1659
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1659.diff