Skip to content

Conversation

@TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Jul 27, 2021

Backport of JDK-8257497. The actual fix applies cleanly. Copyright year update doesn't. The test CheckCertAKID.java uses KnownOIDs which is not part of the JDK in 11u. We're using a copy in the test library instead. Skipped changes in ExtOptionCamelCase.java which belongs to JDK-8231950 which is not in 11u.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8257497: Update keytool to create AKID from the SKID of the issuing certificate as specified by RFC 5280

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/167/head:pull/167
$ git checkout pull/167

Update a local copy of the PR:
$ git checkout pull/167
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/167/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 167

View PR using the GUI difftool:
$ git pr show -t 167

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/167.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 27, 2021

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 05301f5fd2b5f2357024a3d7bb788270861220a8 8257497: Update keytool to create AKID from the SKID of the issuing certificate as specified by RFC 5280 Jul 27, 2021
@openjdk
Copy link

openjdk bot commented Jul 27, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Jul 27, 2021
@mlbridge
Copy link

mlbridge bot commented Jul 27, 2021

Webrevs

Copy link
Contributor

@RealCLanger RealCLanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk
Copy link

openjdk bot commented Aug 3, 2021

@TheRealMDoerr This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8257497: Update keytool to create AKID from the SKID of the issuing certificate as specified by RFC 5280

Reviewed-by: clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 21 new commits pushed to the master branch:

  • 815d3e1: 8267625: AARCH64: typo in LIR_Assembler::emit_profile_type
  • 4da3fb8: 8268261: C2: assert(n != __null) failed: Bad immediate dominator info.
  • 05c7697: 8269668: [aarch64] java.library.path not including /usr/lib64
  • 37bc75b: 8241768: git needs .gitattributes
  • 351cb48: 8225583: Examine the HttpResponse.BodySubscribers for null handling and multiple subscriptions
  • 8ae2846: 8232243: Wrong caret position in JTextPane on Windows with a screen resolution > 100%
  • a2af649: 8268775: Password is being converted to String in AccessibleJPasswordField
  • 7639f8c: 8262470: Printed GlyphVector outline with low DPI has bad quality on Windows
  • 0e2d915: 8257620: Do not use objc_msgSend_stret to get macOS version
  • 6e60332: 8269795: C2: Out of bounds array load floats above its range check in loop peeling resulting in SEGV
  • ... and 11 more: https://git.openjdk.java.net/jdk11u-dev/compare/f700d37d2b3d8c23d50defc19853c68bb60027ab...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 3, 2021
@TheRealMDoerr
Copy link
Contributor Author

Thanks for the review!
/integrate

@openjdk
Copy link

openjdk bot commented Aug 4, 2021

Going to push as commit 0c783b0.
Since your change was applied there have been 22 commits pushed to the master branch:

  • aebdee3: 8230674: Heap dumps should exclude dormant CDS archived objects of unloaded classes
  • 815d3e1: 8267625: AARCH64: typo in LIR_Assembler::emit_profile_type
  • 4da3fb8: 8268261: C2: assert(n != __null) failed: Bad immediate dominator info.
  • 05c7697: 8269668: [aarch64] java.library.path not including /usr/lib64
  • 37bc75b: 8241768: git needs .gitattributes
  • 351cb48: 8225583: Examine the HttpResponse.BodySubscribers for null handling and multiple subscriptions
  • 8ae2846: 8232243: Wrong caret position in JTextPane on Windows with a screen resolution > 100%
  • a2af649: 8268775: Password is being converted to String in AccessibleJPasswordField
  • 7639f8c: 8262470: Printed GlyphVector outline with low DPI has bad quality on Windows
  • 0e2d915: 8257620: Do not use objc_msgSend_stret to get macOS version
  • ... and 12 more: https://git.openjdk.java.net/jdk11u-dev/compare/f700d37d2b3d8c23d50defc19853c68bb60027ab...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Aug 4, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 4, 2021
@openjdk
Copy link

openjdk bot commented Aug 4, 2021

@TheRealMDoerr Pushed as commit 0c783b0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@TheRealMDoerr TheRealMDoerr deleted the 8257497_keytool branch August 4, 2021 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants