-
Notifications
You must be signed in to change notification settings - Fork 251
8257497: Update keytool to create AKID from the SKID of the issuing certificate as specified by RFC 5280 #167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into |
|
This backport pull request has now been updated with issue from the original commit. |
RealCLanger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
|
@TheRealMDoerr This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 21 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
Thanks for the review! |
|
Going to push as commit 0c783b0.
Your commit was automatically rebased without conflicts. |
|
@TheRealMDoerr Pushed as commit 0c783b0. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Backport of JDK-8257497. The actual fix applies cleanly. Copyright year update doesn't. The test CheckCertAKID.java uses KnownOIDs which is not part of the JDK in 11u. We're using a copy in the test library instead. Skipped changes in ExtOptionCamelCase.java which belongs to JDK-8231950 which is not in 11u.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/167/head:pull/167$ git checkout pull/167Update a local copy of the PR:
$ git checkout pull/167$ git pull https://git.openjdk.java.net/jdk11u-dev pull/167/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 167View PR using the GUI difftool:
$ git pr show -t 167Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/167.diff