Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7188098: TEST_BUG: closed/javax/sound/midi/Synthesizer/Receiver/bug6186488.java fails #1671

Closed
wants to merge 1 commit into from

Conversation

elifaslan1
Copy link
Contributor

@elifaslan1 elifaslan1 commented Jan 19, 2023

7188098: TEST_BUG: closed/javax/sound/midi/Synthesizer/Receiver/bug6186488.java fails


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-7188098: TEST_BUG: closed/javax/sound/midi/Synthesizer/Receiver/bug6186488.java fails

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1671/head:pull/1671
$ git checkout pull/1671

Update a local copy of the PR:
$ git checkout pull/1671
$ git pull https://git.openjdk.org/jdk11u-dev pull/1671/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1671

View PR using the GUI difftool:
$ git pr show -t 1671

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1671.diff

@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Jan 19, 2023
@bridgekeeper
Copy link

bridgekeeper bot commented Jan 19, 2023

Hi @elifaslan1, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user elifaslan1" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@openjdk openjdk bot changed the title Backport c640fe42c2b5e6668a2a875678be44443942c868 7188098: TEST_BUG: closed/javax/sound/midi/Synthesizer/Receiver/bug6186488.java fails Jan 19, 2023
@openjdk
Copy link

openjdk bot commented Jan 19, 2023

This backport pull request has now been updated with issue from the original commit.

@elifaslan1
Copy link
Contributor Author

/covered

@bridgekeeper bridgekeeper bot added the oca-verify Needs verification of OCA signatory status label Jan 19, 2023
@bridgekeeper
Copy link

bridgekeeper bot commented Jan 19, 2023

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

@phohensee
Copy link
Member

I can verify that Elif Aslan (@elifaslan1) is an Amazon employee and therefore covered under the OCA.

@phohensee
Copy link
Member

Tagged the JBS issue.

@bridgekeeper bridgekeeper bot removed oca Needs verification of OCA signatory status oca-verify Needs verification of OCA signatory status labels Jan 27, 2023
@openjdk
Copy link

openjdk bot commented Jan 27, 2023

@elifaslan1 This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

7188098: TEST_BUG: closed/javax/sound/midi/Synthesizer/Receiver/bug6186488.java fails

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

  • d183dc2: 8295685: Update Libpng to 1.6.38
  • 4e13da9: 8230374: maxOutputSize, instead of javatest.maxOutputSize, should be used in TEST.properties
  • 644b50e: 8294705: Disable an assertion in test/jdk/java/util/DoubleStreamSums/CompensatedSums.java
  • 60d46cd: 8192931: Regression test java/awt/font/TextLayout/CombiningPerf.java fails
  • 08e09c5: 8144030: [macosx] test java/awt/Frame/ShapeNotSetSometimes/ShapeNotSetSometimes.java fails (again)
  • e1ca75a: 8208077: File.listRoots performance degradation
  • 3c51c43: 8280048: Missing comma in copyright header
  • c02f7fe: 6528710: sRGB-ColorSpace to sRGB-ColorSpace Conversion
  • 684a870: 8300119: CgroupMetrics.getTotalMemorySize0() can report invalid results on 32 bit systems
  • de8c37a: 8297951: C2: Create skeleton predicates for all If nodes in loop predication
  • ... and 8 more: https://git.openjdk.org/jdk11u-dev/compare/f4eccbe1c704719e14ea05539c752e5492ce1520...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 27, 2023
@mlbridge
Copy link

mlbridge bot commented Jan 27, 2023

Webrevs

@elifaslan1
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jan 30, 2023
@openjdk
Copy link

openjdk bot commented Jan 30, 2023

@elifaslan1
Your change (at version 9081e95) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Jan 30, 2023

Going to push as commit 271c46b.
Since your change was applied there have been 18 commits pushed to the master branch:

  • d183dc2: 8295685: Update Libpng to 1.6.38
  • 4e13da9: 8230374: maxOutputSize, instead of javatest.maxOutputSize, should be used in TEST.properties
  • 644b50e: 8294705: Disable an assertion in test/jdk/java/util/DoubleStreamSums/CompensatedSums.java
  • 60d46cd: 8192931: Regression test java/awt/font/TextLayout/CombiningPerf.java fails
  • 08e09c5: 8144030: [macosx] test java/awt/Frame/ShapeNotSetSometimes/ShapeNotSetSometimes.java fails (again)
  • e1ca75a: 8208077: File.listRoots performance degradation
  • 3c51c43: 8280048: Missing comma in copyright header
  • c02f7fe: 6528710: sRGB-ColorSpace to sRGB-ColorSpace Conversion
  • 684a870: 8300119: CgroupMetrics.getTotalMemorySize0() can report invalid results on 32 bit systems
  • de8c37a: 8297951: C2: Create skeleton predicates for all If nodes in loop predication
  • ... and 8 more: https://git.openjdk.org/jdk11u-dev/compare/f4eccbe1c704719e14ea05539c752e5492ce1520...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 30, 2023
@openjdk openjdk bot closed this Jan 30, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jan 30, 2023
@openjdk
Copy link

openjdk bot commented Jan 30, 2023

@phohensee @elifaslan1 Pushed as commit 271c46b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Jan 30, 2023

@phohensee The command sponsor can only be used in open pull requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants