Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8262981: Create implementation for NSAccessibilitySlider protocol #1674

Closed
wants to merge 25 commits into from

Conversation

Autumn808
Copy link
Contributor

@Autumn808 Autumn808 commented Jan 19, 2023

This backport is JDK-8262981. This backport has a CSR and has need two other backports to be dependent to properly build. Backports JDK-8265278, and JDK-8265291. These are all part of the 28 Backport series here: JDK-8152350.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Integration blocker

 ⚠️ Dependency #1670 must be integrated first

Issue

  • JDK-8262981: Create implementation for NSAccessibilitySlider protocol

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1674/head:pull/1674
$ git checkout pull/1674

Update a local copy of the PR:
$ git checkout pull/1674
$ git pull https://git.openjdk.org/jdk11u-dev pull/1674/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1674

View PR using the GUI difftool:
$ git pr show -t 1674

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1674.diff

martinuy and others added 25 commits December 28, 2022 14:09
Reviewed-by: mbaesken
Backport-of: 3c40771d02b34027b53c8f3097e124ac9eddd030
Reviewed-by: mbaesken, avoitylov
Backport-of: e733e55de88e63e129f15edefc602c050339b38a
Reviewed-by: mbalao
Backport-of: 911c24564444096c0c98f6dc308220d48b42d6d3
Reviewed-by: mbaesken, mbalao
Backport-of: 4c7b057380d7656c8c275b526d1918de6a625cc4
Reviewed-by: mbalao
Backport-of: a2668f58ccc3b7c7d74e2903128b08d97aac5798
Reviewed-by: mbaesken, mbalao
Backport-of: fb692840530fa07174f9ad5c9f77d593e503a155
Reviewed-by: mbaesken, mbalao
Backport-of: 40959ac32b81c333f04628be227107762b78a7da
Reviewed-by: mbaesken, mbalao
Backport-of: f1de79f38fcff10ccaf232f79df0a94e84751ff7
Reviewed-by: mbaesken, mbalao
Backport-of: 4df2fd2d1ca8ed73de6ac8b2f6a51ff93e3dac6d
Reviewed-by: mbaesken
Backport-of: ca126c9025ad975d9086d5f967d35a76425c13ca
…rtion Error

Reviewed-by: mbaesken
Backport-of: e94ca7d3fc9b5946d5b808f98e334529054c4f39
Reviewed-by: mbalao
Backport-of: fd837649811c866c144c9133d211fb5ad8f994a7
…hr_HR

8299483: ProblemList java/text/Format/NumberFormat/CurrencyFormat.java

Backport-of: cf6c041bd82a9b62780ef3126e93865fac8c0444
…L check

Backport-of: 2f8a5c2eca0dc3dad08b7b2c33394ac214907008
… awt_parseImage.c

Backport-of: 98fa48c330941efe6588a907b383802a11ed0e6b
…dows 11

Backport-of: f9137cb7b79f86e96247e7b4bc4abb03857afe75
Reviewed-by: mbaesken
Backport-of: f2c3f352bbe7222d7a43fa26f091372ecef20a68
Reviewed-by: mbaesken
Backport-of: ead308168e3c240c85f62d7030efed28dea43b34
@bridgekeeper
Copy link

bridgekeeper bot commented Jan 19, 2023

👋 Welcome back Autumn808! A progress list of the required criteria for merging this PR into pr/1670 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@Autumn808 Autumn808 closed this Jan 19, 2023
@openjdk openjdk bot changed the title Backport 9d669c912d3977027f321a5e6b7f045ca2ce9482 8262981: Create implementation for NSAccessibilitySlider protocol Jan 19, 2023
@openjdk
Copy link

openjdk bot commented Jan 19, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Jan 19, 2023
@openjdk
Copy link

openjdk bot commented Jan 19, 2023

⚠️ @Autumn808 This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 19, 2023
@Autumn808 Autumn808 deleted the JDK-8262981 branch January 19, 2023 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
7 participants