Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8261352: Create implementation for component peer for all the components who should be ignored in a11y interactions #1675

Closed

Conversation

WithEnoughCoffee
Copy link
Contributor

@WithEnoughCoffee WithEnoughCoffee commented Jan 20, 2023

Clean backport JDK-8261352 on of 28 https://bugs.openjdk.org/browse/JDK-8152350


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8261352: Create implementation for component peer for all the components who should be ignored in a11y interactions

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1675/head:pull/1675
$ git checkout pull/1675

Update a local copy of the PR:
$ git checkout pull/1675
$ git pull https://git.openjdk.org/jdk11u-dev pull/1675/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1675

View PR using the GUI difftool:
$ git pr show -t 1675

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1675.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 20, 2023

👋 Welcome back Autumn808! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport e543a5009847a8e3ccbb047b93e3cc6fb261ef8c 8261352: Create implementation for component peer for all the components who should be ignored in a11y interactions Jan 20, 2023
@openjdk
Copy link

openjdk bot commented Jan 20, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 20, 2023

@Autumn808 This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8261352: Create implementation for component peer for all the components who should be ignored in a11y interactions

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 20, 2023
@mlbridge
Copy link

mlbridge bot commented Jan 20, 2023

Webrevs

@WithEnoughCoffee
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jan 23, 2023
@openjdk
Copy link

openjdk bot commented Jan 23, 2023

@Autumn808
Your change (at version 8875e80) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Jan 23, 2023

Going to push as commit c9ce60b.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 23, 2023
@openjdk openjdk bot closed this Jan 23, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jan 23, 2023
@openjdk
Copy link

openjdk bot commented Jan 23, 2023

@phohensee @Autumn808 Pushed as commit c9ce60b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@WithEnoughCoffee WithEnoughCoffee deleted the JDK-8261352 branch March 4, 2023 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants