-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8295405: Add cause in a couple of IllegalArgumentException and InvalidParameterException shown by sun/security/pkcs11 tests #1696
Conversation
👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
Windows presubmit tests fail because of bug in getting jtreg (java version detection is broken) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Appears to be a clean backport from 17u. Ltgm.
@MBaesken This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
Hi Paul, thanks for the review ! /integrate |
Going to push as commit 727ae39.
Your commit was automatically rebased without conflicts. |
backport 8295405 to jdk11u-dev
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1696/head:pull/1696
$ git checkout pull/1696
Update a local copy of the PR:
$ git checkout pull/1696
$ git pull https://git.openjdk.org/jdk11u-dev pull/1696/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1696
View PR using the GUI difftool:
$ git pr show -t 1696
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1696.diff