Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8295405: Add cause in a couple of IllegalArgumentException and InvalidParameterException shown by sun/security/pkcs11 tests #1696

Closed
wants to merge 1 commit into from

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Jan 30, 2023

backport 8295405 to jdk11u-dev


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8295405: Add cause in a couple of IllegalArgumentException and InvalidParameterException shown by sun/security/pkcs11 tests

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1696/head:pull/1696
$ git checkout pull/1696

Update a local copy of the PR:
$ git checkout pull/1696
$ git pull https://git.openjdk.org/jdk11u-dev pull/1696/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1696

View PR using the GUI difftool:
$ git pr show -t 1696

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1696.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 30, 2023

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport d5d34241e21305379f1858556f225e7645cd294e 8295405: Add cause in a couple of IllegalArgumentException and InvalidParameterException shown by sun/security/pkcs11 tests Jan 30, 2023
@openjdk
Copy link

openjdk bot commented Jan 30, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jan 30, 2023
@mlbridge
Copy link

mlbridge bot commented Jan 30, 2023

Webrevs

@MBaesken
Copy link
Member Author

Windows presubmit tests fail because of bug in getting jtreg (java version detection is broken)

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appears to be a clean backport from 17u. Ltgm.

@openjdk
Copy link

openjdk bot commented Jan 30, 2023

@MBaesken This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8295405: Add cause in a couple of IllegalArgumentException and InvalidParameterException shown by sun/security/pkcs11 tests

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 271c46b: 7188098: TEST_BUG: closed/javax/sound/midi/Synthesizer/Receiver/bug6186488.java fails

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 30, 2023
@MBaesken
Copy link
Member Author

MBaesken commented Feb 1, 2023

Hi Paul, thanks for the review !

/integrate

@openjdk
Copy link

openjdk bot commented Feb 1, 2023

Going to push as commit 727ae39.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 64d7622: 8301397: [11u, 17u] Bump jtreg to fix issue with build JDK 11.0.18
  • 271c46b: 7188098: TEST_BUG: closed/javax/sound/midi/Synthesizer/Receiver/bug6186488.java fails

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 1, 2023
@openjdk openjdk bot closed this Feb 1, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 1, 2023
@openjdk
Copy link

openjdk bot commented Feb 1, 2023

@MBaesken Pushed as commit 727ae39.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants