Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8282036: Change java/util/zip/ZipFile/DeleteTempJar.java to stop HttpServer cleanly in case of exceptions #1699

Closed
wants to merge 2 commits into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jan 30, 2023

I backport this for parity with 11.0.19-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8282036: Change java/util/zip/ZipFile/DeleteTempJar.java to stop HttpServer cleanly in case of exceptions

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1699/head:pull/1699
$ git checkout pull/1699

Update a local copy of the PR:
$ git checkout pull/1699
$ git pull https://git.openjdk.org/jdk11u-dev pull/1699/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1699

View PR using the GUI difftool:
$ git pr show -t 1699

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1699.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 30, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 784fa0add77a3e473e2cdbdcc27b3ed076678565 8282036: Change java/util/zip/ZipFile/DeleteTempJar.java to stop HttpServer cleanly in case of exceptions Jan 30, 2023
@openjdk
Copy link

openjdk bot commented Jan 30, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 30, 2023

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8282036: Change java/util/zip/ZipFile/DeleteTempJar.java to stop HttpServer cleanly in case of exceptions

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 30, 2023
@mlbridge
Copy link

mlbridge bot commented Jan 30, 2023

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Feb 1, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Feb 1, 2023

Going to push as commit b10ad19.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 54692ca: 8209935: Test to cover CodeSource.getCodeSigners()
  • a6d4402: 8217730: Split up MakeBase.gmk
  • 727ae39: 8295405: Add cause in a couple of IllegalArgumentException and InvalidParameterException shown by sun/security/pkcs11 tests

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 1, 2023
@openjdk openjdk bot closed this Feb 1, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 1, 2023
@openjdk
Copy link

openjdk bot commented Feb 1, 2023

@GoeLin Pushed as commit b10ad19.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant