Skip to content

Conversation

@TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Jul 28, 2021

Backport of JDK-8268775. Doesn't apply cleanly because cleanup JDK-8211300 is not in 11u. Taken new version which includes cleanup.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8268775: Password is being converted to String in AccessibleJPasswordField

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/170/head:pull/170
$ git checkout pull/170

Update a local copy of the PR:
$ git checkout pull/170
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/170/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 170

View PR using the GUI difftool:
$ git pr show -t 170

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/170.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 28, 2021

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 97e0e9e73d12c2b8e58ca2540d5153c10984731d 8268775: Password is being converted to String in AccessibleJPasswordField Jul 28, 2021
@openjdk
Copy link

openjdk bot commented Jul 28, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Jul 28, 2021
@mlbridge
Copy link

mlbridge bot commented Jul 28, 2021

Webrevs

Copy link
Contributor

@zhengyu123 zhengyu123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk
Copy link

openjdk bot commented Jul 29, 2021

@TheRealMDoerr This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8268775: Password is being converted to String in AccessibleJPasswordField

Reviewed-by: zgu, kizune

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 7639f8c: 8262470: Printed GlyphVector outline with low DPI has bad quality on Windows
  • 0e2d915: 8257620: Do not use objc_msgSend_stret to get macOS version

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 29, 2021
@TheRealMDoerr
Copy link
Contributor Author

Thanks for the review!
/integrate

@openjdk
Copy link

openjdk bot commented Jul 30, 2021

Going to push as commit a2af649.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 7639f8c: 8262470: Printed GlyphVector outline with low DPI has bad quality on Windows
  • 0e2d915: 8257620: Do not use objc_msgSend_stret to get macOS version

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jul 30, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 30, 2021
@openjdk
Copy link

openjdk bot commented Jul 30, 2021

@TheRealMDoerr Pushed as commit a2af649.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@TheRealMDoerr TheRealMDoerr deleted the 8268775_JPassword branch July 30, 2021 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants