Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8264299: Create implementation of native accessibility peer for ScrollPane and ScrollBar Java Accessibility roles #1704

Closed
wants to merge 4 commits into from

Conversation

WithEnoughCoffee
Copy link
Contributor

@WithEnoughCoffee WithEnoughCoffee commented Feb 2, 2023

Clean backport JDK-8264299 This backport is part of the 28 backport Accessibility series JDK-8152350.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8264299: Create implementation of native accessibility peer for ScrollPane and ScrollBar Java Accessibility roles

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1704/head:pull/1704
$ git checkout pull/1704

Update a local copy of the PR:
$ git checkout pull/1704
$ git pull https://git.openjdk.org/jdk11u-dev pull/1704/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1704

View PR using the GUI difftool:
$ git pr show -t 1704

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1704.diff

Pankaj Bansal and others added 2 commits January 30, 2023 16:22
@bridgekeeper
Copy link

bridgekeeper bot commented Feb 2, 2023

👋 Welcome back Autumn808! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 6c107fdff289cc553df12ee10b0c8002b84059b2 8264299: Create implementation of native accessibility peer for ScrollPane and ScrollBar Java Accessibility roles Feb 2, 2023
@openjdk
Copy link

openjdk bot commented Feb 2, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Feb 2, 2023
@mlbridge
Copy link

mlbridge bot commented Feb 2, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Feb 7, 2023

⚠️ @Autumn808 This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes to JSlider.java are not part of the original commit openjdk/jdk@6c107fd.

@WithEnoughCoffee WithEnoughCoffee deleted the JDK-8264299 branch March 1, 2023 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants