Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8264304: Create implementation for NSAccessibilityToolbar protocol peer #1706

Closed
wants to merge 2 commits into from

Conversation

Autumn808
Copy link
Contributor

@Autumn808 Autumn808 commented Feb 3, 2023

Clean backport JDK-8264304. Part of 28 Accessibility backport https://bugs.openjdk.org/browse/JDK-8152350.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8264304: Create implementation for NSAccessibilityToolbar protocol peer

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1706/head:pull/1706
$ git checkout pull/1706

Update a local copy of the PR:
$ git checkout pull/1706
$ git pull https://git.openjdk.org/jdk11u-dev pull/1706/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1706

View PR using the GUI difftool:
$ git pr show -t 1706

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1706.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 3, 2023

👋 Welcome back Autumn808! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 4d26f22b9adcf7cecca5316348ef670ac2dbc365 8264304: Create implementation for NSAccessibilityToolbar protocol peer Feb 3, 2023
@openjdk
Copy link

openjdk bot commented Feb 3, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Feb 3, 2023
@mlbridge
Copy link

mlbridge bot commented Feb 3, 2023

Webrevs

@Autumn808 Autumn808 changed the base branch from master to pr/1705 February 3, 2023 22:12
@Autumn808 Autumn808 changed the base branch from pr/1705 to master February 3, 2023 22:12
@openjdk
Copy link

openjdk bot commented Feb 3, 2023

@Autumn808 this pull request can not be integrated into pr/1705 due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout JDK-8264304
git fetch https://git.openjdk.org/jdk11u-dev pr/1705
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge pr/1705"
git push

@openjdk openjdk bot added merge-conflict Pull request has merge conflict with target branch and removed merge-conflict Pull request has merge conflict with target branch labels Feb 3, 2023
@bridgekeeper
Copy link

bridgekeeper bot commented Mar 4, 2023

@Autumn808 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@Autumn808 Autumn808 closed this Mar 10, 2023
@Autumn808 Autumn808 deleted the JDK-8264304 branch March 10, 2023 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant