Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8267066: New NSAccessibility peers should return they roles and subroles directly #1711

Closed
wants to merge 5 commits into from

Conversation

Autumn808
Copy link
Contributor

@Autumn808 Autumn808 commented Feb 7, 2023

This Backport was clean and needed to implement NSAccessibility peers needs to have their roles and subroles to be told directly instead of relying on the property map stored in JavaComponentAccessibility. This backport is being added to the series of 28 Accessibility backports JDK-8152350.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8267066: New NSAccessibility peers should return they roles and subroles directly

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1711/head:pull/1711
$ git checkout pull/1711

Update a local copy of the PR:
$ git checkout pull/1711
$ git pull https://git.openjdk.org/jdk11u-dev pull/1711/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1711

View PR using the GUI difftool:
$ git pr show -t 1711

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1711.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 7, 2023

👋 Welcome back Autumn808! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport d86f91642d7dcf829b8093ebed336d4386bff67a 8267066: New NSAccessibility peers should return they roles and subroles directly Feb 7, 2023
@openjdk
Copy link

openjdk bot commented Feb 7, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Feb 7, 2023
@openjdk
Copy link

openjdk bot commented Feb 7, 2023

⚠️ @Autumn808 This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 7, 2023
@mlbridge
Copy link

mlbridge bot commented Feb 7, 2023

Webrevs

@Autumn808 Autumn808 closed this Mar 3, 2023
@Autumn808 Autumn808 deleted the JDK-8267066 branch March 3, 2023 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
1 participant