Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8286030: Avoid JVM crash when containers share the same /tmp dir #1716

Closed
wants to merge 2 commits into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Feb 10, 2023

I backport this for parity with 11.0.19-oracle.

In 11, there is a perfMem file in each os directory.
In 17, they were merged into a single file in posix, which is touched by the original
change backported here.
So I had to distribute the changes to multiple files.
But the changes would have applied clean. On top,
I "evaluated" the ifdef LINUX statements accordingly.
I edited aix, bsd and linux. On aix, I checked the build
is still working. bsd and linux get the ususal testing.
As I have no means at all to test Solaris, i left it out.
This does not matter funcionally, because the changes
out of the #ifdef Linux parts are cosmetic improvements.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8286030: Avoid JVM crash when containers share the same /tmp dir

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1716/head:pull/1716
$ git checkout pull/1716

Update a local copy of the PR:
$ git checkout pull/1716
$ git pull https://git.openjdk.org/jdk11u-dev pull/1716/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1716

View PR using the GUI difftool:
$ git pr show -t 1716

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1716.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 10, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport d52e18c92d307f5f6e9e649d410a54bef3a910da 8286030: Avoid JVM crash when containers share the same /tmp dir Feb 10, 2023
@openjdk
Copy link

openjdk bot commented Feb 10, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Feb 10, 2023
@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 10, 2023
@mlbridge
Copy link

mlbridge bot commented Feb 10, 2023

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@openjdk
Copy link

openjdk bot commented Feb 10, 2023

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8286030: Avoid JVM crash when containers share the same /tmp dir

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 10, 2023
@GoeLin
Copy link
Member Author

GoeLin commented Feb 14, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Feb 14, 2023

Going to push as commit c58a066.
Since your change was applied there have been 5 commits pushed to the master branch:

  • 43a0015: 8297489: Modify TextAreaTextEventTest.java as to verify the content change of TextComponent sends TextEvent
  • d0984df: 8223716: sun/net/www/http/HttpClient/MultiThreadTest.java should be more resilient to unexpected traffic
  • 2c47c45: 8273497: building.md should link to both md and html
  • 816e53b: 8298129: Let checkpoint event sizes grow beyond u4 limit
  • 0c42ee4: 8295774: Write a test to verify List sends ItemEvent/ActionEvent

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 14, 2023
@openjdk openjdk bot closed this Feb 14, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 14, 2023
@openjdk
Copy link

openjdk bot commented Feb 14, 2023

@GoeLin Pushed as commit c58a066.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8286030 branch February 14, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants