Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8261071: AArch64: Refactor interpreter native wrappers #172

Closed
wants to merge 1 commit into from

Conversation

@VladimirKempik
Copy link

@VladimirKempik VladimirKempik commented Jul 28, 2021

This backport is needed as a prerequest for macos-aarch64. Applies almost clean, only in one place the constant was "1ull" on 17 and "1" on 11.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8261071: AArch64: Refactor interpreter native wrappers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/172/head:pull/172
$ git checkout pull/172

Update a local copy of the PR:
$ git checkout pull/172
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/172/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 172

View PR using the GUI difftool:
$ git pr show -t 172

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/172.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 28, 2021

👋 Welcome back vkempik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jul 28, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 28, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Jul 28, 2021

@VladimirKempik @VladimirKempik can only mark backport pull requests, with an original hash, as clean

@VladimirKempik VladimirKempik changed the title 8261071: AArch64: Refactor interpreter native wrappers Backport 682e78e89b35c05590a5bc490e87ae3cab864c02 Jul 28, 2021
@openjdk openjdk bot changed the title Backport 682e78e89b35c05590a5bc490e87ae3cab864c02 8261071: AArch64: Refactor interpreter native wrappers Jul 28, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 28, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Jul 28, 2021
@VladimirKempik
Copy link
Author

@VladimirKempik VladimirKempik commented Jul 28, 2021

/clean

@openjdk openjdk bot added the clean label Jul 28, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 28, 2021

@VladimirKempik @VladimirKempik this backport pull request is now marked as clean

@VladimirKempik
Copy link
Author

@VladimirKempik VladimirKempik commented Jul 29, 2021

8248414 needs to be backported as well, after which this backport will apply cleanly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant