Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8289562: Change bugs.java.com and bugreport.java.com URL's to https #1720

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Feb 13, 2023

I backport this for parity with 11.0.19-oracle.

It didn't apply well, but as the change is trivial fixing it was straight forward:

patching file src/jdk.compiler/share/classes/com/sun/tools/javac/resources/javac.properties
Resolved.

src/jdk.compiler/share/classes/com/sun/tools/javac/resources/javac_de.properties
File not in 11.

patching file src/jdk.compiler/share/classes/com/sun/tools/javac/resources/javac_ja.properties
Resolved.

patching file src/jdk.compiler/share/classes/com/sun/tools/javac/resources/javac_zh_CN.properties
Resolved.

src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/doclets_de.properties
File not in 11.

patching file src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/doclets_ja.properties
Resolved.

src/jdk.javadoc/share/classes/jdk/javadoc/internal/tool/resources/javadoc_de.properties
File not in 11.

patching file src/jdk.javadoc/share/classes/jdk/javadoc/internal/tool/resources/javadoc_ja.properties
Resolved.

patching file src/jdk.javadoc/share/classes/jdk/javadoc/internal/tool/resources/javadoc_zh_CN.properties
Resolved.

src/jdk.jlink/share/classes/jdk/tools/jlink/resources/jlink_de.properties
File not in 11.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8289562: Change bugs.java.com and bugreport.java.com URL's to https

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1720/head:pull/1720
$ git checkout pull/1720

Update a local copy of the PR:
$ git checkout pull/1720
$ git pull https://git.openjdk.org/jdk11u-dev pull/1720/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1720

View PR using the GUI difftool:
$ git pr show -t 1720

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1720.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 13, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 1f484dae4efaa60cf18a3d4df947c05f1497bd5b 8289562: Change bugs.java.com and bugreport.java.com URL's to https Feb 13, 2023
@openjdk
Copy link

openjdk bot commented Feb 13, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Feb 13, 2023
@mlbridge
Copy link

mlbridge bot commented Feb 13, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Feb 14, 2023

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8289562: Change bugs.java.com and bugreport.java.com URL's to https

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • c58a066: 8286030: Avoid JVM crash when containers share the same /tmp dir
  • 43a0015: 8297489: Modify TextAreaTextEventTest.java as to verify the content change of TextComponent sends TextEvent
  • d0984df: 8223716: sun/net/www/http/HttpClient/MultiThreadTest.java should be more resilient to unexpected traffic
  • 2c47c45: 8273497: building.md should link to both md and html
  • 816e53b: 8298129: Let checkpoint event sizes grow beyond u4 limit

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 14, 2023
@GoeLin
Copy link
Member Author

GoeLin commented Feb 15, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Feb 15, 2023

Going to push as commit b096b9d.
Since your change was applied there have been 16 commits pushed to the master branch:

  • d7a6e6a: 8285093: Introduce UTIL_ARG_WITH
  • 1f0e77e: 8295116: C2: assert(dead->outcnt() == 0 && !dead->is_top()) failed: node must be dead
  • 4c27fa0: 8231595: [TEST] develop a test case for SuspendThreadList including current thread
  • 8773d46: 8223736: jvmti/scenarios/contention/TC04/tc04t001/TestDescription.java fails due to wrong number of MonitorContendedEntered events
  • 6c6006e: 8224024: java/util/concurrent/BlockingQueue/DrainToFails.java testBounded fails intermittently
  • c90bc80: 8129315: java/net/Socket/LingerTest.java and java/net/Socket/ShutdownBoth.java timeout intermittently
  • 3614fb2: 8222430: Add tests for ElementKind predicates
  • 834e072: 8221098: Run java/net/URL/HandlerLoop.java in othervm mode
  • 88d8eb2: 8170705: sun/net/www/protocol/http/StackTraceTest.java fails intermittently with Invalid Http response
  • a220aaf: 8195057: java/util/concurrent/CountDownLatch/Basic.java failed w/ Xcomp
  • ... and 6 more: https://git.openjdk.org/jdk11u-dev/compare/0c42ee469051efe7efe1242e672cdc27114bd4da...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 15, 2023
@openjdk openjdk bot closed this Feb 15, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 15, 2023
@openjdk
Copy link

openjdk bot commented Feb 15, 2023

@GoeLin Pushed as commit b096b9d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8289562 branch February 15, 2023 13:59
@GoeLin
Copy link
Member Author

GoeLin commented Feb 15, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Feb 15, 2023

@GoeLin The command integrate can only be used in open pull requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants