Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8218133: sun/net/www/protocol/http/ProtocolRedirect.java failed with "java.net.ConnectException" #1722

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Feb 13, 2023

I backport this for parity with 11.0.19-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8218133: sun/net/www/protocol/http/ProtocolRedirect.java failed with "java.net.ConnectException"

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1722/head:pull/1722
$ git checkout pull/1722

Update a local copy of the PR:
$ git checkout pull/1722
$ git pull https://git.openjdk.org/jdk11u-dev pull/1722/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1722

View PR using the GUI difftool:
$ git pr show -t 1722

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1722.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 13, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport d176e208985f55745a60fc806dfb369a2cce0781 8218133: sun/net/www/protocol/http/ProtocolRedirect.java failed with "java.net.ConnectException" Feb 13, 2023
@openjdk
Copy link

openjdk bot commented Feb 13, 2023

This backport pull request has now been updated with issue and summary from the original commit.

@openjdk
Copy link

openjdk bot commented Feb 13, 2023

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8218133: sun/net/www/protocol/http/ProtocolRedirect.java failed with "java.net.ConnectException"

Changed the test to use the loopback interface.

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 13, 2023
@mlbridge
Copy link

mlbridge bot commented Feb 13, 2023

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Feb 14, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Feb 14, 2023

Going to push as commit 7d7aa61.
Since your change was applied there have been 4 commits pushed to the master branch:

  • c58a066: 8286030: Avoid JVM crash when containers share the same /tmp dir
  • 43a0015: 8297489: Modify TextAreaTextEventTest.java as to verify the content change of TextComponent sends TextEvent
  • d0984df: 8223716: sun/net/www/http/HttpClient/MultiThreadTest.java should be more resilient to unexpected traffic
  • 2c47c45: 8273497: building.md should link to both md and html

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 14, 2023
@openjdk openjdk bot closed this Feb 14, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 14, 2023
@openjdk
Copy link

openjdk bot commented Feb 14, 2023

@GoeLin Pushed as commit 7d7aa61.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant