Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8171405: java/net/URLConnection/ResendPostBody.java failed with "Error while cleaning up threads after test" #1734

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Feb 14, 2023

I backport this for parity with 11.0.19-oracle.

I had to merge two larger chunks by hand.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8171405: java/net/URLConnection/ResendPostBody.java failed with "Error while cleaning up threads after test"

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1734/head:pull/1734
$ git checkout pull/1734

Update a local copy of the PR:
$ git checkout pull/1734
$ git pull https://git.openjdk.org/jdk11u-dev pull/1734/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1734

View PR using the GUI difftool:
$ git pr show -t 1734

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1734.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 14, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 7b49c40ee96cb5fc78071cd87c7c4edcd50417b3 8171405: java/net/URLConnection/ResendPostBody.java failed with "Error while cleaning up threads after test" Feb 14, 2023
@openjdk
Copy link

openjdk bot commented Feb 14, 2023

This backport pull request has now been updated with issue and summary from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Feb 14, 2023
@mlbridge
Copy link

mlbridge bot commented Feb 14, 2023

Webrevs

@GoeLin GoeLin force-pushed the goetz_backport_8171405 branch from d86f607 to f1d891d Compare February 15, 2023 13:18
@openjdk
Copy link

openjdk bot commented Feb 15, 2023

@GoeLin Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@GoeLin
Copy link
Member Author

GoeLin commented Feb 16, 2023

Pre-submit failure: windows infra issue.
This is a testbug that does not depend on win so I think we can go without these tests.

@openjdk
Copy link

openjdk bot commented Feb 16, 2023

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8171405: java/net/URLConnection/ResendPostBody.java failed with "Error while cleaning up threads after test"

Test cleaned up to improve safe termination

Reviewed-by: clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

  • 0a91274: 8282958: Rendering Issues with Borders on Windows High-DPI systems
  • 6678084: 8279614: The left line of the TitledBorder is not painted on 150 scale factor
  • b096b9d: 8289562: Change bugs.java.com and bugreport.java.com URL's to https
  • d7a6e6a: 8285093: Introduce UTIL_ARG_WITH
  • 1f0e77e: 8295116: C2: assert(dead->outcnt() == 0 && !dead->is_top()) failed: node must be dead
  • 4c27fa0: 8231595: [TEST] develop a test case for SuspendThreadList including current thread
  • 8773d46: 8223736: jvmti/scenarios/contention/TC04/tc04t001/TestDescription.java fails due to wrong number of MonitorContendedEntered events
  • 6c6006e: 8224024: java/util/concurrent/BlockingQueue/DrainToFails.java testBounded fails intermittently
  • c90bc80: 8129315: java/net/Socket/LingerTest.java and java/net/Socket/ShutdownBoth.java timeout intermittently
  • 3614fb2: 8222430: Add tests for ElementKind predicates
  • ... and 4 more: https://git.openjdk.org/jdk11u-dev/compare/c58a06666d93d7c339f9ce3133555083f30ca0e5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 16, 2023
@GoeLin
Copy link
Member Author

GoeLin commented Feb 16, 2023

/integrate

1 similar comment
@GoeLin
Copy link
Member Author

GoeLin commented Feb 16, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Feb 16, 2023

Going to push as commit 5c1748a.
Since your change was applied there have been 18 commits pushed to the master branch:

  • 22be061: 8226917: jvmti/scenarios/contention/TC04/tc04t001/TestDescription.java fails on jvmti->InterruptThread (JVMTI_ERROR_THREAD_NOT_ALIVE)
  • a3d867b: 8226595: jvmti/scenarios/contention/TC04/tc04t001/TestDescription.java still fails due to wrong number of MonitorContendedEntered events
  • 3a2a0f9: 8223463: Replace wildcard address with loopback or local host in tests - part 2
  • 5685e58: 8207248: Reduce incidence of compiler.warn.source.no.bootclasspath in javac tests
  • 0a91274: 8282958: Rendering Issues with Borders on Windows High-DPI systems
  • 6678084: 8279614: The left line of the TitledBorder is not painted on 150 scale factor
  • b096b9d: 8289562: Change bugs.java.com and bugreport.java.com URL's to https
  • d7a6e6a: 8285093: Introduce UTIL_ARG_WITH
  • 1f0e77e: 8295116: C2: assert(dead->outcnt() == 0 && !dead->is_top()) failed: node must be dead
  • 4c27fa0: 8231595: [TEST] develop a test case for SuspendThreadList including current thread
  • ... and 8 more: https://git.openjdk.org/jdk11u-dev/compare/c58a06666d93d7c339f9ce3133555083f30ca0e5...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 16, 2023
@openjdk openjdk bot closed this Feb 16, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 16, 2023
@GoeLin GoeLin deleted the goetz_backport_8171405 branch February 16, 2023 10:30
@openjdk
Copy link

openjdk bot commented Feb 16, 2023

@GoeLin Pushed as commit 5c1748a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk
Copy link

openjdk bot commented Feb 16, 2023

@GoeLin The command integrate can only be used in open pull requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants