Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8227422: sun/net/www/protocol/file/DirPermissionDenied.java failed on Windows 2016 because DirPermissionDenied directory has no read permission #1735

Closed
wants to merge 3 commits into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Feb 14, 2023

I backport this for parity with 11.0.19-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8227422: sun/net/www/protocol/file/DirPermissionDenied.java failed on Windows 2016 because DirPermissionDenied directory has no read permission

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1735/head:pull/1735
$ git checkout pull/1735

Update a local copy of the PR:
$ git checkout pull/1735
$ git pull https://git.openjdk.org/jdk11u-dev pull/1735/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1735

View PR using the GUI difftool:
$ git pr show -t 1735

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1735.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 14, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 0518393598de764a716376a98e436fb717aef9d4 8227422: sun/net/www/protocol/file/DirPermissionDenied.java failed on Windows 2016 because DirPermissionDenied directory has no read permission Feb 14, 2023
@openjdk
Copy link

openjdk bot commented Feb 14, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Feb 14, 2023

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8227422: sun/net/www/protocol/file/DirPermissionDenied.java failed on Windows 2016 because DirPermissionDenied directory has no read permission

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 14, 2023
@mlbridge
Copy link

mlbridge bot commented Feb 14, 2023

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Feb 15, 2023

Pre-submit failure: configure: error: Could not find a C compiler on windows.
Infra issue, unrelated. But as this is a windows fix, I'll restart the tests.

@GoeLin
Copy link
Member Author

GoeLin commented Feb 16, 2023

Pre-submit failure: windows infra issue.
As this is a win fix, I'll wait for the tests.

@GoeLin
Copy link
Member Author

GoeLin commented Feb 17, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Feb 17, 2023

Going to push as commit 43e53a3.
Since your change was applied there have been 5 commits pushed to the master branch:

  • 98e3b0d: 8202621: bad test with broken links needs to be updated
  • bfd05a6: 8302657: [11u] Add missing '(' in makefile after backport of 8218431
  • 1364140: 8284165: Add pid to process reaper thread name
  • 06ee0b6: 8297963: Partially fix string expansion issues in UTIL_DEFUN_NAMED and related macros
  • 630c80e: 8293550: Optionally add get-task-allow entitlement to macos binaries

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 17, 2023
@openjdk openjdk bot closed this Feb 17, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 17, 2023
@openjdk
Copy link

openjdk bot commented Feb 17, 2023

@GoeLin Pushed as commit 43e53a3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant