Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8248306: gc/stress/gclocker/TestExcessGCLockerCollections.java does not compile #1744

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Feb 15, 2023

I backport this for parity with 11.0.19-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8248306: gc/stress/gclocker/TestExcessGCLockerCollections.java does not compile

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1744/head:pull/1744
$ git checkout pull/1744

Update a local copy of the PR:
$ git checkout pull/1744
$ git pull https://git.openjdk.org/jdk11u-dev pull/1744/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1744

View PR using the GUI difftool:
$ git pr show -t 1744

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1744.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 15, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 83fff054980406fa93fb17976d67fc31102a9276 8248306: gc/stress/gclocker/TestExcessGCLockerCollections.java does not compile Feb 15, 2023
@openjdk
Copy link

openjdk bot commented Feb 15, 2023

This backport pull request has now been updated with issue and summary from the original commit.

@openjdk
Copy link

openjdk bot commented Feb 15, 2023

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8248306: gc/stress/gclocker/TestExcessGCLockerCollections.java does not compile

Update the test to use the method suggested in JDK-8244010.

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

  • d942151: 8209774: Refactor shell test javax/xml/jaxp/common/8035437/run.sh to java
  • 131084c: 8035787: SourcePositions are wrong for Strings concatenated with '+' operator
  • 1d32290: 8233462: serviceability/tmtools/jstat tests times out with -Xcomp
  • 5c1748a: 8171405: java/net/URLConnection/ResendPostBody.java failed with "Error while cleaning up threads after test"
  • 22be061: 8226917: jvmti/scenarios/contention/TC04/tc04t001/TestDescription.java fails on jvmti->InterruptThread (JVMTI_ERROR_THREAD_NOT_ALIVE)
  • a3d867b: 8226595: jvmti/scenarios/contention/TC04/tc04t001/TestDescription.java still fails due to wrong number of MonitorContendedEntered events
  • 3a2a0f9: 8223463: Replace wildcard address with loopback or local host in tests - part 2
  • 5685e58: 8207248: Reduce incidence of compiler.warn.source.no.bootclasspath in javac tests
  • 0a91274: 8282958: Rendering Issues with Borders on Windows High-DPI systems
  • 6678084: 8279614: The left line of the TitledBorder is not painted on 150 scale factor
  • ... and 1 more: https://git.openjdk.org/jdk11u-dev/compare/d7a6e6ae495a780c6818dd69ae240ac092e41504...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 15, 2023
@mlbridge
Copy link

mlbridge bot commented Feb 15, 2023

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Feb 16, 2023

re-submit failure: windows infra issue.
This is a testbug that does not depend on win so I think we can go without these tests.

@GoeLin
Copy link
Member Author

GoeLin commented Feb 16, 2023

/backport jdk11u-dev

@openjdk
Copy link

openjdk bot commented Feb 16, 2023

@GoeLin Backport for repo openjdk/jdk11u-dev on branch master was successfully enabled and will be performed once this pull request has been integrated. Further instructions will be provided at that time.

@GoeLin
Copy link
Member Author

GoeLin commented Feb 17, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Feb 17, 2023

Going to push as commit b51ebf8.
Since your change was applied there have been 18 commits pushed to the master branch:

  • cdd3e04: 8221168: java/util/concurrent/CountDownLatch/Basic.java fails
  • 43e53a3: 8227422: sun/net/www/protocol/file/DirPermissionDenied.java failed on Windows 2016 because DirPermissionDenied directory has no read permission
  • 98e3b0d: 8202621: bad test with broken links needs to be updated
  • bfd05a6: 8302657: [11u] Add missing '(' in makefile after backport of 8218431
  • 1364140: 8284165: Add pid to process reaper thread name
  • 06ee0b6: 8297963: Partially fix string expansion issues in UTIL_DEFUN_NAMED and related macros
  • 630c80e: 8293550: Optionally add get-task-allow entitlement to macos binaries
  • d942151: 8209774: Refactor shell test javax/xml/jaxp/common/8035437/run.sh to java
  • 131084c: 8035787: SourcePositions are wrong for Strings concatenated with '+' operator
  • 1d32290: 8233462: serviceability/tmtools/jstat tests times out with -Xcomp
  • ... and 8 more: https://git.openjdk.org/jdk11u-dev/compare/d7a6e6ae495a780c6818dd69ae240ac092e41504...master

Your commit was automatically rebased without conflicts.

@openjdk
Copy link

openjdk bot commented Feb 17, 2023

Creating backport for repo openjdk/jdk11u-dev on branch master

/backport openjdk/jdk11u-dev master

@openjdk openjdk bot added integrated Pull request has been integrated and removed backport=openjdk/jdk11u-dev:master labels Feb 17, 2023
@openjdk openjdk bot closed this Feb 17, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 17, 2023
@openjdk
Copy link

openjdk bot commented Feb 17, 2023

@GoeLin Pushed as commit b51ebf8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk
Copy link

openjdk bot commented Feb 17, 2023

@openjdk[bot] @GoeLin Could not apply backport b51ebf8c to openjdk/jdk11u-dev because the change is already present in the target.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant