Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8301842: JFR: increase checkpoint event size for stacktrace and string pool #1759

Closed
wants to merge 1 commit into from

Conversation

kvergizova
Copy link

@kvergizova kvergizova commented Feb 16, 2023

I'd like to backport JDK-8301842 as a small follow up fix for JDK-8298129 which is already included in 11u.
The first two hunks don't apply cleanly, WriteContent class is absent in 11u as JDK-8226511 is not backported.
Similar changes are made in WriteCheckpointEvent::proccess().
Tested with tier1 and jdk/jfr.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8301842: JFR: increase checkpoint event size for stacktrace and string pool

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1759/head:pull/1759
$ git checkout pull/1759

Update a local copy of the PR:
$ git checkout pull/1759
$ git pull https://git.openjdk.org/jdk11u-dev pull/1759/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1759

View PR using the GUI difftool:
$ git pr show -t 1759

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1759.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 16, 2023

👋 Welcome back evergizova! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 7dfe75cf553193faf709cff6b8b2505680d7cebc 8301842: JFR: increase checkpoint event size for stacktrace and string pool Feb 16, 2023
@openjdk
Copy link

openjdk bot commented Feb 16, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Feb 16, 2023
@mlbridge
Copy link

mlbridge bot commented Feb 16, 2023

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@openjdk
Copy link

openjdk bot commented Feb 21, 2023

@kvergizova This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8301842: JFR: increase checkpoint event size for stacktrace and string pool

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

  • bc29f1e: 8288332: Tier1 validate-source fails after 8279614
  • 183bb36: 8271323: [TESTBUG] serviceability/sa/ClhsdbCDSCore.java fails with -XX:TieredStopAtLevel=1
  • 363586e: 8262060: compiler/whitebox/BlockingCompilation.java timed out
  • 2244467: 8264200: java/nio/channels/DatagramChannel/SRTest.java fails intermittently
  • ffac38f: 8264512: jdk/test/jdk/java/util/prefs/ExportNode.java relies on default platform encoding
  • eb8c6f5: 8261279: sun/util/resources/cldr/TimeZoneNamesTest.java timed out
  • 5f99819: 8261270: MakeMethodNotCompilableTest fails with -XX:TieredStopAtLevel={1,2,3}
  • 013aa4d: 8259265: Refactor UncaughtExceptions shell test as java test.
  • dbee861: 8260576: Typo in compiler/runtime/safepoints/TestRegisterRestoring.java
  • 169b3d2: 8252401: Introduce Utils.TEST_NATIVE_PATH
  • ... and 7 more: https://git.openjdk.org/jdk11u-dev/compare/136414034636feabe2010fd8f6fdef839d6b9227...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 21, 2023
@kvergizova
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Feb 24, 2023

Going to push as commit c692aa9.
Since your change was applied there have been 17 commits pushed to the master branch:

  • bc29f1e: 8288332: Tier1 validate-source fails after 8279614
  • 183bb36: 8271323: [TESTBUG] serviceability/sa/ClhsdbCDSCore.java fails with -XX:TieredStopAtLevel=1
  • 363586e: 8262060: compiler/whitebox/BlockingCompilation.java timed out
  • 2244467: 8264200: java/nio/channels/DatagramChannel/SRTest.java fails intermittently
  • ffac38f: 8264512: jdk/test/jdk/java/util/prefs/ExportNode.java relies on default platform encoding
  • eb8c6f5: 8261279: sun/util/resources/cldr/TimeZoneNamesTest.java timed out
  • 5f99819: 8261270: MakeMethodNotCompilableTest fails with -XX:TieredStopAtLevel={1,2,3}
  • 013aa4d: 8259265: Refactor UncaughtExceptions shell test as java test.
  • dbee861: 8260576: Typo in compiler/runtime/safepoints/TestRegisterRestoring.java
  • 169b3d2: 8252401: Introduce Utils.TEST_NATIVE_PATH
  • ... and 7 more: https://git.openjdk.org/jdk11u-dev/compare/136414034636feabe2010fd8f6fdef839d6b9227...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 24, 2023
@openjdk openjdk bot closed this Feb 24, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 24, 2023
@openjdk
Copy link

openjdk bot commented Feb 24, 2023

@kvergizova Pushed as commit c692aa9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants