8299234: JMX Repository.query performance

[alexeybakhtin]

Almost clean backport of JDK-8299234 to JDK11u

The only difference is the format of the removed ObjectNamePattern class declaration:
private final static class ObjectNamePattern vs private static final class ObjectNamePattern

Performance of the original code:
Benchmark (N) Mode Cnt Score Error Units
JmxBenchmark.queryMBeansForMyObjectName 1000 thrpt 10 78.090 ± 0.206 ops/s
JmxBenchmark.queryMBeansForObjectName 1000 thrpt 10 144.837 ± 0.618 ops/s
JmxBenchmark.queryNamesForMyObjectName 1000 thrpt 10 77.323 ± 1.159 ops/s
JmxBenchmark.queryNamesForObjectName 1000 thrpt 10 144.938 ± 3.588 ops/s

Performance after patch applied:
Benchmark (N) Mode Cnt Score Error Units
JmxBenchmark.queryMBeansForMyObjectName 1000 thrpt 10 108.009 ± 9.615 ops/s
JmxBenchmark.queryMBeansForObjectName 1000 thrpt 10 233.958 ± 12.616 ops/s
JmxBenchmark.queryNamesForMyObjectName 1000 thrpt 10 108.239 ± 10.117 ops/s
JmxBenchmark.queryNamesForObjectName 1000 thrpt 10 258.043 ± 5.981 ops/s

javax/naming and javax/management tests passed

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8299234: JMX Repository.query performance

Reviewers

• Paul Hohensee (@phohensee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/1762/head:pull/1762
$ git checkout pull/1762

Update a local copy of the PR:
$ git checkout pull/1762
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/1762/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1762

View PR using the GUI difftool:
$ git pr show -t 1762

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1762.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back abakhtin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (074b0616)

[phohensee]

Lgtm, but note that this is a performance oriented backport into a legacy JDK of a commit that has not seen production use.

[openjdk]

@alexeybakhtin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8299234: JMX Repository.query performance

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 53 new commits pushed to the master branch:

• 3c8c45e: 8259530: Generated docs contain MIT/GPL-licenced works without reproducing the licence
• 6dedd8a: 8291638: Keep-Alive timeout of 0 should close connection immediately
• 00b7647: 8275721: Name of UTC timezone in a locale changes depending on previous code
• 835f2ca: 8291226: Create Test Cases to cover scenarios for JDK-8278067
• d8993e6: 8291637: HttpClient default keep alive timeout not followed if server sends invalid value
• e12516d: 8303102: jcmd: ManagementAgent.status truncates the text longer than O_BUFLEN
• 88434e5: 8227257: javax/swing/JFileChooser/4847375/bug4847375.java fails with AssertionError
• 75fb8a9: 8301170: perfMemory_windows.cpp add free_security_attr to early returns
• 386addf: 8215575: C2 crash: assert(get_instanceKlass()->is_loaded()) failed: must be at least loaded
• 1516012: 8300205: Swing test bug8078268 make latch timeout configurable
• ... and 43 more: https://git.openjdk.org/jdk11u-dev/compare/bc29f1eb26714ef4a4f1494d9e9cd8aaf9050d7d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[alexeybakhtin]

Lgtm, but note that this is a performance oriented backport into a legacy JDK of a commit that has not seen production use.

Thank you a lot for review

[bridgekeeper]

@alexeybakhtin This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper]

@alexeybakhtin This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.