Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8252532: use Utils.TEST_NATIVE_PATH instead of System.getProperty("test.nativepath") #1765

Closed
wants to merge 3 commits into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Feb 22, 2023

I backport this for parity with 11.0.19-oracle.

test/hotspot/jtreg/runtime/handshake/HandshakeTransitionTest.java
Resolved context, extra argument "true".

test/lib/jdk/test/lib/process/ProcessTools.java
Resolved formatting fixes. Some don't apply because the
formatted comments are not in 11.
I also removed the suppressWarning statement.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8252532: use Utils.TEST_NATIVE_PATH instead of System.getProperty("test.nativepath")

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1765/head:pull/1765
$ git checkout pull/1765

Update a local copy of the PR:
$ git checkout pull/1765
$ git pull https://git.openjdk.org/jdk11u-dev pull/1765/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1765

View PR using the GUI difftool:
$ git pr show -t 1765

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1765.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 22, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@GoeLin GoeLin changed the title Goetz backport 8252532 Backport 4fe6a3da68d2c75a3706ecb9a2d3639711324102 Feb 23, 2023
@openjdk openjdk bot changed the title Backport 4fe6a3da68d2c75a3706ecb9a2d3639711324102 8252532: use Utils.TEST_NATIVE_PATH instead of System.getProperty("test.nativepath") Feb 23, 2023
@openjdk
Copy link

openjdk bot commented Feb 23, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Feb 23, 2023
@mlbridge
Copy link

mlbridge bot commented Feb 23, 2023

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@openjdk
Copy link

openjdk bot commented Feb 24, 2023

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8252532: use Utils.TEST_NATIVE_PATH instead of System.getProperty("test.nativepath")

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 24, 2023
@GoeLin
Copy link
Member Author

GoeLin commented Feb 27, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Feb 27, 2023

Going to push as commit 83456c6.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 27, 2023
@openjdk openjdk bot closed this Feb 27, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 27, 2023
@openjdk
Copy link

openjdk bot commented Feb 27, 2023

@GoeLin Pushed as commit 83456c6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8252532 branch February 1, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants