Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8277346: ProblemList 7 serviceability/sa tests on macosx-x64 #1772

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Feb 24, 2023

I backport this for parity with 11.0.19-oracle.

The tests are already problem listed in 11. I distributed
bugId and platform to the existing tests.

I verified we see some of these failing in our CI, too.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

  • JDK-8277346: ProblemList 7 serviceability/sa tests on macosx-x64
  • JDK-8277351: ProblemList runtime/jni/checked/TestPrimitiveArrayCriticalWithBadParam.java on macosx-x64

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1772/head:pull/1772
$ git checkout pull/1772

Update a local copy of the PR:
$ git checkout pull/1772
$ git pull https://git.openjdk.org/jdk11u-dev pull/1772/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1772

View PR using the GUI difftool:
$ git pr show -t 1772

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1772.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 24, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 86112cb0899bded434cf1424be1cc5b13aa4173c 8277346: ProblemList 7 serviceability/sa tests on macosx-x64 Feb 24, 2023
@openjdk
Copy link

openjdk bot commented Feb 24, 2023

This backport pull request has now been updated with issues from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Feb 24, 2023
@mlbridge
Copy link

mlbridge bot commented Feb 24, 2023

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@openjdk
Copy link

openjdk bot commented Feb 24, 2023

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8277346: ProblemList 7 serviceability/sa tests on macosx-x64
8277351: ProblemList runtime/jni/checked/TestPrimitiveArrayCriticalWithBadParam.java on macosx-x64

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • c692aa9: 8301842: JFR: increase checkpoint event size for stacktrace and string pool

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 24, 2023
@GoeLin
Copy link
Member Author

GoeLin commented Feb 28, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Feb 28, 2023

Going to push as commit cf58d59.
Since your change was applied there have been 11 commits pushed to the master branch:

  • 64434da: 8254267: javax/xml/crypto/dsig/LogParameters.java failed with "RuntimeException: Unexpected log output:"
  • cfb05cb: 8302903: [11u] Add modified test snippet after backport of JDK-8221871
  • 83456c6: 8252532: use Utils.TEST_NATIVE_PATH instead of System.getProperty("test.nativepath")
  • efe4481: 8266974: duplicate property key in java.sql.rowset resource bundle
  • c8c63cb: 8303075: [11u] Add CompileClassWithDebugTest to ProblemList for 8303074
  • 05db322: 8270609: [TESTBUG] java/awt/print/Dialog/DialogCopies.java does not show instruction
  • cb5d79c: 8273895: compiler/ciReplay/TestVMNoCompLevel.java fails due to wrong data size with TieredStopAtLevel=2,3
  • b3820b2: 8273806: compiler/cpuflags/TestSSE4Disabled.java should test for CPU feature explicitly
  • b396137: 8257928: Test image build failure with clang-10 due to -Wmisleading-indentation
  • 411aaff: 8213265: fix missing newlines at end of files
  • ... and 1 more: https://git.openjdk.org/jdk11u-dev/compare/bc29f1eb26714ef4a4f1494d9e9cd8aaf9050d7d...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 28, 2023
@openjdk openjdk bot closed this Feb 28, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 28, 2023
@openjdk
Copy link

openjdk bot commented Feb 28, 2023

@GoeLin Pushed as commit cf58d59.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8277346 branch February 28, 2023 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants