Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8279662: serviceability/sa/ClhsdbScanOops.java can fail due to unexpected GC #1776

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Feb 27, 2023

I backport this for parity with 11.0.19-oracle.

I resolved the Copyright, will mark as clean.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8279662: serviceability/sa/ClhsdbScanOops.java can fail due to unexpected GC

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1776/head:pull/1776
$ git checkout pull/1776

Update a local copy of the PR:
$ git checkout pull/1776
$ git pull https://git.openjdk.org/jdk11u-dev pull/1776/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1776

View PR using the GUI difftool:
$ git pr show -t 1776

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1776.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 27, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport fe0118f8040ce7e5e3d605942443e3a5d442fa92 8279662: serviceability/sa/ClhsdbScanOops.java can fail due to unexpected GC Feb 27, 2023
@openjdk
Copy link

openjdk bot commented Feb 27, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Feb 27, 2023
@GoeLin
Copy link
Member Author

GoeLin commented Feb 27, 2023

/clean

@mlbridge
Copy link

mlbridge bot commented Feb 27, 2023

Webrevs

@openjdk openjdk bot added the clean label Feb 27, 2023
@openjdk
Copy link

openjdk bot commented Feb 27, 2023

@GoeLin This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented Feb 27, 2023

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8279662: serviceability/sa/ClhsdbScanOops.java can fail due to unexpected GC

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • cfb05cb: 8302903: [11u] Add modified test snippet after backport of JDK-8221871

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 27, 2023
@GoeLin
Copy link
Member Author

GoeLin commented Feb 28, 2023

Pre-submit tests: infra problem, jtreg download failed: wget exited with exit code 4
Unrelated.

@GoeLin
Copy link
Member Author

GoeLin commented Feb 28, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Feb 28, 2023

Going to push as commit 18c06bb.
Since your change was applied there have been 3 commits pushed to the master branch:

  • cf58d59: 8277346: ProblemList 7 serviceability/sa tests on macosx-x64
  • 64434da: 8254267: javax/xml/crypto/dsig/LogParameters.java failed with "RuntimeException: Unexpected log output:"
  • cfb05cb: 8302903: [11u] Add modified test snippet after backport of JDK-8221871

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 28, 2023
@openjdk openjdk bot closed this Feb 28, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 28, 2023
@openjdk
Copy link

openjdk bot commented Feb 28, 2023

@GoeLin Pushed as commit 18c06bb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8279662 branch February 28, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant